chore: decouple demo app build #1013

transphorm · 2025-09-08T17:52:12Z

Summary

avoid demo validation when building mobile-sdk-alpha
add build:demo script and update demo workflow to use it
exclude demo app from default yarn build

Testing

node -v && yarn -v
yarn install (fails: unrs-resolver couldn't be built)
yarn workspaces foreach -p -v --topological-dev --since=HEAD run nice --if-present
yarn lint
yarn build
yarn workspace @selfxyz/contracts build (fails: Hardhat config error)
yarn types
yarn workspace @selfxyz/mobile-sdk-alpha test
yarn build:demo

https://chatgpt.com/codex/tasks/task_b_68bf0c6dd7cc832d9ca882a5161d6d1b

Summary by CodeRabbit

New Features
- Introduced a standalone mobile-sdk-demo app with dedicated build and start commands.
Documentation
- Updated guides and README to reference mobile-sdk-demo and revised start/build/test instructions.
Refactor
- Adjusted Metro config paths for the demo app to simplify workspace resolution.
Tests
- Updated demo app test commands to target mobile-sdk-demo.
Chores
- Renamed demo app package and updated workspace scripts.
- CI updated to build/test the mobile-sdk-demo app and use a new demo build workflow.

coderabbitai · 2025-09-08T17:52:18Z

Warning

Rate limit exceeded

@transphorm has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 34 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between f83f57b and 98605cb.

⛔ Files ignored due to path filters (12)

packages/mobile-sdk-demo/android/app/src/main/res/mipmap-hdpi/ic_launcher.png is excluded by !**/*.png
packages/mobile-sdk-demo/android/app/src/main/res/mipmap-hdpi/ic_launcher_round.png is excluded by !**/*.png
packages/mobile-sdk-demo/android/app/src/main/res/mipmap-mdpi/ic_launcher.png is excluded by !**/*.png
packages/mobile-sdk-demo/android/app/src/main/res/mipmap-mdpi/ic_launcher_round.png is excluded by !**/*.png
packages/mobile-sdk-demo/android/app/src/main/res/mipmap-xhdpi/ic_launcher.png is excluded by !**/*.png
packages/mobile-sdk-demo/android/app/src/main/res/mipmap-xhdpi/ic_launcher_round.png is excluded by !**/*.png
packages/mobile-sdk-demo/android/app/src/main/res/mipmap-xxhdpi/ic_launcher.png is excluded by !**/*.png
packages/mobile-sdk-demo/android/app/src/main/res/mipmap-xxhdpi/ic_launcher_round.png is excluded by !**/*.png
packages/mobile-sdk-demo/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher.png is excluded by !**/*.png
packages/mobile-sdk-demo/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher_round.png is excluded by !**/*.png
packages/mobile-sdk-demo/ios/Podfile.lock is excluded by !**/*.lock
yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (10)

.github/workflows/mobile-sdk-demo-ci.yml (2 hunks)
docs/METRO_WORKSPACE_GUIDE.md (2 hunks)
package.json (1 hunks)
packages/mobile-sdk-alpha/README.md (1 hunks)
packages/mobile-sdk-alpha/package.json (2 hunks)
packages/mobile-sdk-alpha/scripts/build-demo.mjs (1 hunks)
packages/mobile-sdk-alpha/vitest.config.ts (1 hunks)
packages/mobile-sdk-demo/jest.config.cjs (1 hunks)
packages/mobile-sdk-demo/metro.config.cjs (2 hunks)
packages/mobile-sdk-demo/package.json (1 hunks)

Walkthrough

Renames and migrates the demo app from demo-app to mobile-sdk-demo across CI, scripts, docs, and configs. Updates CI workflow filters and steps, root and package scripts, Metro config paths, and package names. Removes a demo validation step, adjusts test exclusions, and updates documentation references.

Changes

Cohort / File(s)	Summary
CI workflow updates `.github/workflows/mobile-sdk-demo-ci.yml`	PR trigger path moved to `packages/mobile-sdk-demo/**`; build/test steps target `mobile-sdk-demo`; build uses `yarn build:demo`.
Root workspace and scripts `package.json`	Removes `packages/mobile-sdk-alpha/demo-app` from workspaces; adds `build:demo`; excludes `mobile-sdk-demo` from root `build`; updates `build:mobile-sdk` and `demo:mobile` to use `mobile-sdk-demo`.
SDK package scripts `packages/mobile-sdk-alpha/package.json`	Points all demo scripts to `mobile-sdk-demo`; removes `demo:validate`; build no longer runs demo validation.
SDK build helper `packages/mobile-sdk-alpha/scripts/build-demo.mjs`	Changes DEMO_APP path to `../mobile-sdk-demo`.
SDK test config `packages/mobile-sdk-alpha/vitest.config.ts`	Removes `demo-app/` from exclude list (now only excludes `node_modules/`).
Demo app package rename `packages/mobile-sdk-demo/package.json`	Renames package `"name"` from `demo-app` to `mobile-sdk-demo`.
Demo Metro config `packages/mobile-sdk-demo/metro.config.cjs`	Adjusts workspaceRoot fallback and extraNodeModules paths one level up (from `../../..` to `../..`).
Docs update `docs/METRO_WORKSPACE_GUIDE.md`, `packages/mobile-sdk-alpha/README.md`	Updates references from `demo-app` to `mobile-sdk-demo`; adjusts commands and symlink cleanup snippet; adds `yarn run:demo` line in README.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Dev as Developer
  participant CI as CI Workflow
  participant Monorepo as Yarn Workspaces
  participant Demo as mobile-sdk-demo
  participant SDK as @selfxyz/mobile-sdk-alpha

  Dev->>CI: Open PR touching packages/mobile-sdk-demo/**
  CI->>Monorepo: yarn workspaces foreach -R -t --from mobile-sdk-demo run build
  Monorepo->>SDK: Build SDK (no demo:validate)
  Monorepo->>Demo: Build demo app
  CI->>Demo: yarn workspace mobile-sdk-demo test
  CI->>Demo: yarn build:demo
  CI-->>Dev: Report build/test status

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

feat: modernize mobile sdk build pipeline #877 — Also modifies mobile SDK build scripts and tooling; likely part of the same build/CI refactor.

Suggested reviewers

remicolin
aaronmgdr

Poem

New name on the marquee, a tidy show,
Scripts in step, the pipelines flow.
Metro maps shortened paths to go,
Tests march on where demos grow.
One app reborn—hello, mobile-sdk-demo! 🚀

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch codex/update-build-scripts-for-demo-app

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

transphorm · 2025-09-08T23:38:04Z

@coderabbitai summary

coderabbitai · 2025-09-08T23:38:09Z

✅ Actions performed

Summary regeneration triggered.

transphorm · 2025-09-08T23:48:33Z

@coderabbitai full review

coderabbitai · 2025-09-08T23:48:38Z

✅ Actions performed

Full review triggered.

* feat: add mock document generator demo * feat: add mock document generator * fixes * chore: refresh workflow cache * update lock * build * updates * more fixes * code rabbit feedback * compiles * save wip * updates * merge with dev and fixes * fix: align hoisting and demo Jest resolver (#1003) * chore(app): map common src paths and declare svg flag module * ci fix * update lock * save wip * chore: address yarn lock issues (#1004) * address yarn lock issues * fix postinstall * fix ci * use metro js proxy * android build working for /app * save wip * fix merge * pipeline fixes * format * fix pipelines * bump limit and split * fix pipeline issues * chore: decouple demo app build (#1013) * chore: decouple demo app build * chore: move demo app to workspace * chore: unpublish demo workspace * fix mobile sdk tests * updates * remove polyfills * update merge * update resolutions * update resolutions * fix merge * fix paths * save wip * save wip fixes rd2 * working android * update lock * save wip ios building * fix merge * readd public key * fixes * ci fixes * fixes * fix web building * fix ci * fix tests * update lock * fix ci rd2 * formatting and fix ci * fix * finalize ci fixes * fix tests and metro config paths for building * save wip * install missing package for pipeline * fix wip app building * wip react config * save working emulator compile * first round of pr fixes and feedback * clean up demo app artifacts from sdk * Add Gradle wrapper files for mobile-sdk-demo Android build - Added gradlew, gradlew.bat, and gradle/wrapper/ directory - Updated .gitignore to allow committing Gradle wrapper files - Fixes Android build error: spawn ./gradlew ENOENT * codex feedback and fixes * fix tests * file renames * revert back to dev * add types * coderabbit fixes * fix tests * fix tests * fix test * fixes * fix wip coderabbit issues * coderabbit suggestions rd 2 * fix ci pipelines and addresss warnings * cr fixes * convert kebab to camelCase * save wip fixes * update reinstall and lock files * fixes * remove file * fix lint * fix polyfill fallback issues * ensure that mock document is not on ofac list * prettier

chore: decouple demo app build

eb548a2

transphorm added the codex label Sep 8, 2025 — with ChatGPT Codex Connector

transphorm added 2 commits September 8, 2025 12:40

chore: move demo app to workspace

e1e0306

chore: unpublish demo workspace

c989c72

fix mobile sdk tests

98605cb

transphorm merged commit 4ccd499 into codex/ideate-mock-document-screen-for-demo-app Sep 8, 2025
16 checks passed

transphorm deleted the codex/update-build-scripts-for-demo-app branch September 8, 2025 23:52

This was referenced Sep 11, 2025

[SELF-700] feat: add mock document generator demo #995

Merged

chore package versions ci #1076

Closed

This was referenced Sep 29, 2025

[SELF-781] chore: add polish to the mobile demo app #1135

Merged

SELF-831: Add mobile demo app e2e tests #1185

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: decouple demo app build #1013

chore: decouple demo app build #1013

Uh oh!

transphorm commented Sep 8, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Sep 8, 2025 •

edited

Loading

Rate limit exceeded

Uh oh!

transphorm commented Sep 8, 2025

Uh oh!

coderabbitai bot commented Sep 8, 2025

Uh oh!

transphorm commented Sep 8, 2025

Uh oh!

coderabbitai bot commented Sep 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chore: decouple demo app build #1013

chore: decouple demo app build #1013

Uh oh!

Conversation

transphorm commented Sep 8, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

transphorm commented Sep 8, 2025

Uh oh!

coderabbitai bot commented Sep 8, 2025

Uh oh!

transphorm commented Sep 8, 2025

Uh oh!

coderabbitai bot commented Sep 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

transphorm commented Sep 8, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 8, 2025 •

edited

Loading