Skip to content

Conversation

@transphorm
Copy link
Member

Summary

  • remove unsupported workspaces.nohoist and restrict hoisting via .yarnrc.yml
  • add @babel/runtime dependency for @selfxyz/mobile-sdk-alpha
  • map root modules in demo app Jest config and add stub for @react-native-picker/picker
  • point mobile app TypeScript paths at common/src and declare react-native-svg-circle-country-flags

Testing

  • yarn workspace @selfxyz/mobile-app lint (fails: Unable to resolve path to module 'react-native-svg-circle-country-flags')
  • yarn workspace @selfxyz/mobile-app types (fails: errors in common/src/utils/trees.ts)
  • yarn workspace @selfxyz/mobile-app test (fails: web app build could not resolve 'react-native-svg-circle-country-flags')

https://chatgpt.com/codex/tasks/task_b_68b9dd8390f0832db7acf96700d85dd0

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 4, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (3)
  • main
  • dev
  • staging

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/verify-fix-for-metro-bundler-issues-sokrcv

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@transphorm transphorm marked this pull request as draft September 4, 2025 21:54
@transphorm transphorm force-pushed the codex/verify-fix-for-metro-bundler-issues-sokrcv branch from 479d816 to 2767c1c Compare September 5, 2025 01:26
@transphorm transphorm marked this pull request as ready for review September 8, 2025 03:25
@transphorm transphorm merged commit eb6c3c4 into codex/ideate-mock-document-screen-for-demo-app Sep 8, 2025
20 checks passed
@transphorm transphorm deleted the codex/verify-fix-for-metro-bundler-issues-sokrcv branch September 8, 2025 04:53
transphorm added a commit that referenced this pull request Sep 27, 2025
* feat: add mock document generator demo

* feat: add mock document generator

* fixes

* chore: refresh workflow cache

* update lock

* build

* updates

* more fixes

* code rabbit feedback

* compiles

* save wip

* updates

* merge with dev and fixes

* fix: align hoisting and demo Jest resolver (#1003)

* chore(app): map common src paths and declare svg flag module

* ci fix

* update lock

* save wip

* chore: address yarn lock issues (#1004)

* address yarn lock issues

* fix postinstall

* fix ci

* use metro js proxy

* android build working for /app

* save wip

* fix merge

* pipeline fixes

* format

* fix pipelines

* bump limit and split

* fix pipeline issues

* chore: decouple demo app build (#1013)

* chore: decouple demo app build

* chore: move demo app to workspace

* chore: unpublish demo workspace

* fix mobile sdk tests

* updates

* remove polyfills

* update merge

* update resolutions

* update resolutions

* fix merge

* fix paths

* save wip

* save wip fixes rd2

* working android

* update lock

* save wip ios building

* fix merge

* readd public key

* fixes

* ci fixes

* fixes

* fix web building

* fix ci

* fix tests

* update lock

* fix ci rd2

* formatting and fix ci

* fix

* finalize ci fixes

* fix tests and metro config paths for building

* save wip

* install missing package for pipeline

* fix wip app building

* wip react config

* save working emulator compile

* first round of pr fixes and feedback

* clean up demo app artifacts from sdk

* Add Gradle wrapper files for mobile-sdk-demo Android build

- Added gradlew, gradlew.bat, and gradle/wrapper/ directory
- Updated .gitignore to allow committing Gradle wrapper files
- Fixes Android build error: spawn ./gradlew ENOENT

* codex feedback and fixes

* fix tests

* file renames

* revert back to dev

* add types

* coderabbit fixes

* fix tests

* fix tests

* fix test

* fixes

* fix wip coderabbit issues

* coderabbit suggestions rd 2

* fix ci pipelines and addresss warnings

* cr fixes

* convert kebab to camelCase

* save wip fixes

* update reinstall and lock files

* fixes

* remove file

* fix lint

* fix polyfill fallback issues

* ensure that mock document is not on ofac list

* prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants