pr feedback

Author: transphorm

packages/mobile-sdk-alpha/src/client.ts

@@ -1,6 +1,6 @@
 import { defaultConfig } from './config/defaults';
 import { mergeConfig } from './config/merge';
-import { notImplemented } from './errors';
+import { notImplemented, sdkError } from './errors';
 import type {
   Adapters,
   Config,
@@ -44,7 +44,13 @@ const optionalDefaults: Partial<Adapters> = {
  * @param param0.adapters - Implementations of required SDK adapters.
  * @returns Initialized client exposing document scanning, validation, and proof APIs.
  */
-export function createSelfClient({ config, adapters }: { config: Config; adapters: Partial<Adapters> }): SelfClient {
+export function createSelfClient({
+  config,
+  adapters,
+}: {
+  config: Partial<Config>;
+  adapters: Partial<Adapters>;
+}): SelfClient {
   const cfg = mergeConfig(defaultConfig, config);
   const required: (keyof Adapters)[] = ['scanner', 'network', 'crypto'];
   for (const name of required) {
@@ -134,7 +140,9 @@ export function createSelfClient({ config, adapters }: { config: Config; adapter
     if (!adapters.network) throw notImplemented('network');
     if (!adapters.crypto) throw notImplemented('crypto');
     const timeoutMs = opts.timeoutMs ?? cfg.timeouts?.proofMs ?? defaultConfig.timeouts.proofMs;
-    void _adapters.clock.sleep(timeoutMs!, opts.signal).then(() => emit('error', new Error('timeout')));
+    void _adapters.clock
+      .sleep(timeoutMs!, opts.signal)
+      .then(() => emit('error', sdkError('timeout', 'SELF_ERR_PROOF_TIMEOUT', 'proof', true)));
     return {
       id: 'stub',
       status: 'pending',

packages/mobile-sdk-alpha/src/types/public.ts

@@ -1,5 +1,23 @@
+import type { SdkError } from '../errors';
+
 export type { PassportData } from '@selfxyz/common/utils/types';
 export type { PassportValidationCallbacks } from '../validation/document';
+
+// Platform-neutral HTTP shapes
+export type RequestLike = string | URL;
+export interface RequestInitLike {
+  method?: string;
+  headers?: Record<string, string>;
+  body?: string | ArrayBuffer | ArrayBufferView | Uint8Array;
+}
+export interface HttpResponseLike {
+  status: number;
+  headers: Record<string, string>;
+  text(): Promise<string>;
+  json<T = unknown>(): Promise<T>;
+  arrayBuffer(): Promise<ArrayBuffer>;
+}
+
 /**
  * Runtime configuration options for the SDK.
  */
@@ -25,7 +43,7 @@ export interface CryptoAdapter {
  * Minimal wrapper around `fetch` used for HTTP requests.
  */
 export interface HttpAdapter {
-  fetch(input: RequestInfo, init?: RequestInit): Promise<Response>;
+  fetch(input: RequestLike, init?: RequestInitLike): Promise<HttpResponseLike>;
 }
 /**
  * Parsed machine-readable zone (MRZ) details from a passport.
@@ -132,7 +150,7 @@ export interface RegistrationStatus {
 export interface SDKEventMap {
   progress: Progress;
   state: string;
-  error: Error;
+  error: SdkError;
 }
 /**
  * Names of events emitted by {@link SelfClient}.

packages/mobile-sdk-alpha/tests/client.test.ts

@@ -84,7 +84,15 @@ const scanner: ScannerAdapter = {
 };
 
 const network: NetworkAdapter = {
-  http: { fetch: async () => new Response(null) },
+  http: {
+    fetch: async () => ({
+      status: 200,
+      headers: {},
+      text: async () => '',
+      json: async () => ({}),
+      arrayBuffer: async () => new ArrayBuffer(0),
+    }),
+  },
   ws: {
     connect: () => ({
       send: () => {},