Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: CSS background-image icons reworked #263

Open
fjf2002 opened this issue Jun 19, 2023 · 2 comments
Open

Suggestion: CSS background-image icons reworked #263

fjf2002 opened this issue Jun 19, 2023 · 2 comments

Comments

@fjf2002
Copy link

fjf2002 commented Jun 19, 2023

The WRAPs with icons are quite nice, we use them a lot.

In my opinion background-image is a problematic solution for applying the icon; it won't print by default, for example. Also dw2pdf seems to have its problems with loading the icons(?)

Would anybody prefer

  • converting for example .wrap_info { background-image: url(xyz); } to something like .wrap_info:before { content: url(xyz); }
  • thus enabling printing the icons
  • (some more css stuff needed here...)

?

@fjf2002 fjf2002 changed the title Suggestion: CSS background-image reworked Suggestion: CSS background-image icons reworked Jun 19, 2023
@Klap-in
Copy link
Collaborator

Klap-in commented Jun 19, 2023

general note about dw2pdf: dw2pdf uses a very limited css set as default, so probably the dw2pdf needs in all cases specific css, which should be explictly be tested with the mPDF library used by dw2pdf.

@fjf2002
Copy link
Author

fjf2002 commented Jun 19, 2023

Ah I now understand: The default browser settings won't print background-images, and background-colors neither. So my suggested solution would still leave the background-color issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants