Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] allow re-type seed words if checksum not valid #380

Open
htprww opened this issue May 3, 2024 · 6 comments
Open

[Enhancement] allow re-type seed words if checksum not valid #380

htprww opened this issue May 3, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@htprww
Copy link

htprww commented May 3, 2024

Describe the new feature or enhancement

I got into this issue that when I restore the wallet using seed words, I have a typo in one of the words, and did not pass the final checksum. Then the krux gets back to the Restore wallet main menu, so I have to re-type all.

I would like to stay in the seed words typing page, and allow the users to navigate back the word list, so I can just fix the typo for the single word.

@htprww htprww added the enhancement New feature or request label May 3, 2024
@tadeubas
Copy link
Contributor

tadeubas commented May 3, 2024

But how would you fix the first word and keep everything else? Isn't it a restart of the process in general?

I was thinking about this, but it would only work if you made a typo in just the last word

@jdlcdl
Copy link
Collaborator

jdlcdl commented May 3, 2024

would it be like a multi-choice menu, one option per word... move up or down then select (or touch) to change that word (so would have to del the chars, retype them and go) and then jump to the mnemonic_is_valid() check?

@htprww
Copy link
Author

htprww commented May 3, 2024

I think we need the "back" and "forward" button, so the user could navigate back to see the previous entered words.
The already entered words will be automatically filled in when you navigate back.

So if I see the invalid checksum at the last step, I will probably just need to navigate back to check the words I have already typed in, and only need to modify the typos.

@odudex
Copy link
Member

odudex commented May 3, 2024

It's important to note that it is impossible to make typos; Krux will only allow valid words at each step.

@Garrysoon
Copy link

It's important to note that it is impossible to make typos; Krux will only allow valid words at each step.

the typo could be in the whole word

@jdlcdl
Copy link
Collaborator

jdlcdl commented Jun 7, 2024

Imagining an important use case on this, rather than "sloppy data entry":

User did the best they could to backup their mnemonic on metal, but still it was partially destroyed. They're missing letters from 2 adjacent words, and they'll need to do trial/error until they fall on a valid mnemonic with a familiar passphrase-less fingerprint.

I can see a few places where it would be useful to be able to back-out and edit words (or word numbers).

A) They can see the final mnemonic in one screen but have not yet accepted... could back out here if they see a problem.
B) They've accepted the final list, but it's not a valid mnemonic... should be able to edit here.
C) They've accepted and the mnemonic is valid. The passphrase-less bip32 fingerprint should be visible here, so that they can back out and edit words if it's not familiar.

Instead of going "prev" and "next" inside a keyboard, I think the list should be visible in one "edit mnemonic" screen, "prev", "next" to highlight different words and "select" to jump into the keyboard to edit that one -- then "Go" would bring them back to the "edit mnemonic" screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants