Skip to content

Commit

Permalink
[ci] upgrade upload and download actions to v4 (#13516)
Browse files Browse the repository at this point in the history
  • Loading branch information
titusfortner authored Jan 26, 2024
1 parent 65c4abd commit e7bd6c4
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 10 deletions.
11 changes: 9 additions & 2 deletions .github/workflows/bazel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ on:
required: false
type: string
default: ''
artifact-name:
description: Name of artifact to upload
required: false
type: string
default: 'ignore-artifacts'

jobs:
bazel:
Expand Down Expand Up @@ -141,11 +146,13 @@ jobs:
prerelease: true
files: ${{ inputs.nightly-release-files }}
- name: Save changes
if: ${{ always() && inputs.artifact-name != 'ignore-artifacts' }}
run: |
git diff > changes.patch
- name: "Upload changes"
uses: actions/upload-artifact@v3
if: ${{ always() && inputs.artifact-name != 'ignore-artifacts' }}
uses: actions/upload-artifact@v4
with:
name: patch-file
name: ${{ inputs.artifact-name }}
path: changes.patch
retention-days: 6
14 changes: 7 additions & 7 deletions .github/workflows/ci-rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
- name: "Rename binary"
run: mv rust/target/release/selenium-manager.exe selenium-manager-windows.exe
- name: "Upload release binary"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: selenium-manager-windows
path: selenium-manager-windows.exe
Expand Down Expand Up @@ -83,7 +83,7 @@ jobs:
- name: "Rename binary"
run: mv rust/target/debug/selenium-manager.exe selenium-manager-windows-debug.exe
- name: "Upload release binary"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: selenium-manager-windows-debug
path: selenium-manager-windows-debug.exe
Expand Down Expand Up @@ -111,7 +111,7 @@ jobs:
- name: "Rename binary"
run: mv rust/target/x86_64-unknown-linux-musl/release/selenium-manager selenium-manager-linux
- name: "Upload release binary"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: selenium-manager-linux
path: selenium-manager-linux
Expand Down Expand Up @@ -140,7 +140,7 @@ jobs:
tar -cvf ../../../../selenium-manager-linux-debug.tar selenium-manager
working-directory: rust
- name: "Upload release binary"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: selenium-manager-linux-debug
path: selenium-manager-linux-debug.tar
Expand Down Expand Up @@ -170,7 +170,7 @@ jobs:
target/x86_64-apple-darwin/release/selenium-manager
working-directory: rust
- name: "Upload release binary"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: selenium-manager-macos
path: rust/target/selenium-manager-macos
Expand Down Expand Up @@ -202,7 +202,7 @@ jobs:
tar -cvf ../../selenium-manager-macos-debug.tar selenium-manager
working-directory: rust
- name: "Upload release binary"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: selenium-manager-macos-debug
path: selenium-manager-macos-debug.tar
Expand All @@ -220,7 +220,7 @@ jobs:
token: ${{ secrets.SELENIUM_CI_TOKEN }}
repository: SeleniumHQ/selenium_manager_artifacts
- name: "Download Artifacts"
uses: actions/download-artifact@v2
uses: actions/download-artifact@v4
with:
path: artifacts
- name: "Prepare and Commit"
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/pin-browsers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ jobs:
name: Pin Browsers
cache-key: pin-browsers
run: bazel run //scripts:pinned_browsers
artifact-name: pinned-browsers

pull-request:
if: github.repository_owner == 'seleniumhq'
Expand All @@ -23,7 +24,7 @@ jobs:
- name: Download patch
uses: actions/download-artifact@v4
with:
name: patch-file
name: pinned-browsers
- name: Apply Patch
run: |
git apply changes.patch
Expand Down

0 comments on commit e7bd6c4

Please sign in to comment.