Skip to content

Commit

Permalink
[py] put the fix in the wrong place
Browse files Browse the repository at this point in the history
  • Loading branch information
titusfortner committed Dec 2, 2022
1 parent 01a47b4 commit d03ad02
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 3 additions & 0 deletions py/selenium/webdriver/common/selenium_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ def driver_location(self, browser: str) -> str:
if browser not in allowed:
raise SeleniumManagerException(f"{browser} is not a valid browser. Choose one of: {allowed}")

if browser == 'ie':
browser = 'iexplorer'

binary, flag, browser = str(self.get_binary()), "--browser", browser
result = self.run((binary, flag, browser))
executable = result.split("\t")[-1].strip()
Expand Down
3 changes: 1 addition & 2 deletions py/selenium/webdriver/common/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,7 @@ def start(self) -> None:
if "executable needs to be in PATH" in err.msg:
logger.debug("driver not found in PATH, trying Selenium Manager")
browser = self.__class__.__module__.split(".")[-2]
if browser == 'ie':
browser = 'iexplorer'

try:
path = SeleniumManager().driver_location(browser)
except WebDriverException as new_err:
Expand Down

0 comments on commit d03ad02

Please sign in to comment.