[grid] Fixing driver configuration parsing

This covers the case again when the config is passed through the CLI. Fixes #13531
SeleniumHQ · Feb 5, 2024 · 878e186 · 878e186
1 parent 5c214ba
commit 878e186
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/java/src/org/openqa/selenium/grid/node/config/NodeFlags.java b/java/src/org/openqa/selenium/grid/node/config/NodeFlags.java
@@ -151,9 +151,10 @@ public class NodeFlags implements HasRoles {
               + "file to improve readability. Command line example: "
               + "--driver-configuration display-name=\"Firefox Nightly\" max-sessions=2 "
               + "webdriver-path=\"/usr/local/bin/geckodriver\" "
-              + "stereotype='{\"browserName\": \"firefox\", \"browserVersion\": \"86\", "
-              + "\"moz:firefoxOptions\": "
-              + "{\"binary\":\"/Applications/Firefox Nightly.app/Contents/MacOS/firefox\"}}'",
+              + "stereotype=\"{\\\"browserName\\\": \\\"firefox\\\", "
+              + "\\\"browserVersion\\\": \\\"86\\\", "
+              + "\\\"moz:firefoxOptions\\\": "
+              + "{\\\"binary\":\"/Applications/Firefox Nightly.app/Contents/MacOS/firefox\\\"}}\"",
       arity = 4,
       variableArity = true,
       splitter = NonSplittingSplitter.class)

diff --git a/java/src/org/openqa/selenium/grid/node/config/NodeOptions.java b/java/src/org/openqa/selenium/grid/node/config/NodeOptions.java
@@ -370,6 +370,10 @@ private void addDriverConfigs(
         .ifPresent(
             drivers -> {
               List<Map<String, String>> configList = new ArrayList<>();
+              if (drivers.isEmpty()) {
+                // This is the case when the configuration is provided through the CLI.
+                config.getAll(NODE_SECTION, "driver-configuration").ifPresent(drivers::add);
+              }
 
               // iterate over driver configurations
               for (List<String> driver : drivers) {