K8s: Instead of probe to restart Distributor, adding event bus heartbeat to prevent steal connection (#2995)

Signed-off-by: Viet Nguyen Duc <[email protected]>

Author: VietND96

EventBus/start-selenium-grid-eventbus.sh

@@ -54,6 +54,10 @@ if [ ! -z "$SE_EXTERNAL_URL" ]; then
   append_se_opts "--external-url" "${SE_EXTERNAL_URL}"
 fi
 
+if [ ! -z "${SE_EVENT_BUS_HEARTBEAT_PERIOD}" ]; then
+  append_se_opts "--eventbus-heartbeat-period" "${SE_EVENT_BUS_HEARTBEAT_PERIOD}"
+fi
+
 if [ "${SE_ENABLE_TLS}" = "true" ]; then
   # Configure truststore for the server
   if [ ! -z "$SE_JAVA_SSL_TRUST_STORE" ]; then

Hub/start-selenium-grid-hub.sh

@@ -133,6 +133,10 @@ if [ ! -z "${CONFIG_FILE}" ]; then
   append_se_opts "--config" "${CONFIG_FILE}"
 fi
 
+if [ ! -z "${SE_EVENT_BUS_HEARTBEAT_PERIOD}" ]; then
+  append_se_opts "--eventbus-heartbeat-period" "${SE_EVENT_BUS_HEARTBEAT_PERIOD}"
+fi
+
 EXTRA_LIBS=""
 if [ -n "${SE_EXTRA_LIBS}" ]; then
   EXTRA_LIBS="--ext ${SE_EXTRA_LIBS}"

Standalone/start-selenium-standalone.sh

@@ -99,6 +99,10 @@ if [ ! -z "$SE_EXTERNAL_URL" ]; then
   append_se_opts "--external-url" "${SE_EXTERNAL_URL}"
 fi
 
+if [ ! -z "${SE_EVENT_BUS_HEARTBEAT_PERIOD}" ]; then
+  append_se_opts "--eventbus-heartbeat-period" "${SE_EVENT_BUS_HEARTBEAT_PERIOD}"
+fi
+
 if [ "${SE_ENABLE_TLS}" = "true" ]; then
   # Configure truststore for the server
   if [ ! -z "$SE_JAVA_SSL_TRUST_STORE" ]; then

StandaloneDocker/start-selenium-grid-docker.sh

@@ -69,6 +69,10 @@ if [ ! -z "$SE_EXTERNAL_URL" ]; then
   append_se_opts "--external-url" "${SE_EXTERNAL_URL}"
 fi
 
+if [ ! -z "${SE_EVENT_BUS_HEARTBEAT_PERIOD}" ]; then
+  append_se_opts "--eventbus-heartbeat-period" "${SE_EVENT_BUS_HEARTBEAT_PERIOD}"
+fi
+
 if [ "${SE_ENABLE_TLS}" = "true" ]; then
   # Configure truststore for the server
   if [ ! -z "$SE_JAVA_SSL_TRUST_STORE" ]; then

charts/selenium-grid/CONFIGURATION.md

@@ -40,7 +40,7 @@ A Helm chart for creating a Selenium Grid Server in Kubernetes
 | global.seleniumGrid.defaultNodeStartupProbe | string | `"exec"` | Set default startup probe method for all nodes (supplied values: httpGet, exec). If not set, the default is httpGet |
 | global.seleniumGrid.defaultNodeReadinessProbe | string | `"exec"` | Set default readiness probe method for all nodes (supplied values: httpGet, exec). If not set, the default is httpGet |
 | global.seleniumGrid.defaultNodeLivenessProbe | string | `"exec"` | Set default readiness probe method for all nodes (supplied values: httpGet, exec). If not set, the default is httpGet |
-| global.seleniumGrid.defaultComponentLivenessProbe | string | `"exec"` | Set default liveness probe method for all nodes (supplied values: httpGet, exec). If not set, the default is httpGet |
+| global.seleniumGrid.defaultComponentLivenessProbe | string | `"httpGet"` | Set default liveness probe method for all nodes (supplied values: httpGet, exec). If not set, the default is httpGet |
 | global.seleniumGrid.stdoutProbeLog | bool | `false` | Probe logs output can be retrieved using `kubectl logs`. Noted: this will not work if shareProcessNamespace is enabled |
 | global.seleniumGrid.revisionHistoryLimit | int | `10` | Specify how many old ReplicaSets for this Deployment you want to retain. The rest will be garbage-collected in the background. |
 | global.seleniumGrid.structuredLogs | bool | `false` | Whether to enable structured logging |

charts/selenium-grid/values.yaml

@@ -25,7 +25,7 @@ global:
     # -- Set default readiness probe method for all nodes (supplied values: httpGet, exec). If not set, the default is httpGet
     defaultNodeLivenessProbe: exec
     # -- Set default liveness probe method for all nodes (supplied values: httpGet, exec). If not set, the default is httpGet
-    defaultComponentLivenessProbe: exec
+    defaultComponentLivenessProbe: httpGet
     # -- Probe logs output can be retrieved using `kubectl logs`. Noted: this will not work if shareProcessNamespace is enabled
     stdoutProbeLog: false
     # -- Specify how many old ReplicaSets for this Deployment you want to retain. The rest will be garbage-collected in the background.