Skip to content

Commit

Permalink
docs: update rclone configs in sample
Browse files Browse the repository at this point in the history
Config: no_check_bucket - don't attempt to check the bucket exists or create it
This needed if the user you are using does not have bucket creation permissions
It's useful when trying to minimise the number of transactions rclone does if you know the bucket exists already

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
VietND96 committed Mar 10, 2024
1 parent 5c92a89 commit 5a23107
Showing 7 changed files with 11 additions and 0 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -562,6 +562,7 @@ services:
- RCLONE_CONFIG_S3_ACCESS_KEY_ID=xxx
- RCLONE_CONFIG_S3_SECRET_ACCESS_KEY=xxx
- RCLONE_CONFIG_S3_ENDPOINT=https://storage.googleapis.com
- RCLONE_CONFIG_S3_NO_CHECK_BUCKET=true
```
`SE_VIDEO_FILE_NAME=auto` will use the session id as the video file name. This ensures that the video file name is unique to upload.
1 change: 1 addition & 0 deletions charts/selenium-grid/README.md
Original file line number Diff line number Diff line change
@@ -527,6 +527,7 @@ videoRecorder:
RCLONE_CONFIG_MYS3_ACCESS_KEY_ID: "xxx"
RCLONE_CONFIG_MYS3_SECRET_ACCESS_KEY: "xxx"
RCLONE_CONFIG_MYS3_ENDPOINT: "https://storage.googleapis.com"
RCLONE_CONFIG_MYS3_NO_CHECK_BUCKET: "true"
```

Those two ways are equivalent. You can choose one of them or combine them. When both config file and ENV vars are set, value in `upload.conf` will take precedence.
2 changes: 2 additions & 0 deletions charts/selenium-grid/values.yaml
Original file line number Diff line number Diff line change
@@ -1080,6 +1080,7 @@ videoRecorder:
# RCLONE_CONFIG_S3_ACL: "private"
# RCLONE_CONFIG_S3_ACCESS_KEY_ID: "xxx"
# RCLONE_CONFIG_S3_SECRET_ACCESS_KEY: "xxx"
# RCLONE_CONFIG_S3_NO_CHECK_BUCKET: "true"
# RCLONE_CONFIG_GS_TYPE: "s3"
# RCLONE_CONFIG_GS_PROVIDER: "GCS"
# RCLONE_CONFIG_GS_ENV_AUTH: "true"
@@ -1089,6 +1090,7 @@ videoRecorder:
# RCLONE_CONFIG_GS_ACCESS_KEY_ID: "xxx"
# RCLONE_CONFIG_GS_SECRET_ACCESS_KEY: "xxx"
# RCLONE_CONFIG_GS_ENDPOINT: "https://storage.googleapis.com"
# RCLONE_CONFIG_GS_NO_CHECK_BUCKET: "true"
ports:
- 9000
resources:
3 changes: 3 additions & 0 deletions docker-compose-v3-video-upload.yml
Original file line number Diff line number Diff line change
@@ -53,6 +53,7 @@ services:
- RCLONE_CONFIG_S3_ACCESS_KEY_ID=${GS_ACCESS_KEY_ID}
- RCLONE_CONFIG_S3_SECRET_ACCESS_KEY=${GS_SECRET_ACCESS_KEY}
- RCLONE_CONFIG_S3_ENDPOINT=https://storage.googleapis.com
- RCLONE_CONFIG_S3_NO_CHECK_BUCKET=true

edge_video:
image: selenium/video:ffmpeg-6.1-20240224
@@ -73,6 +74,7 @@ services:
- RCLONE_CONFIG_S3_ACCESS_KEY_ID=${GS_ACCESS_KEY_ID}
- RCLONE_CONFIG_S3_SECRET_ACCESS_KEY=${GS_SECRET_ACCESS_KEY}
- RCLONE_CONFIG_S3_ENDPOINT=https://storage.googleapis.com
- RCLONE_CONFIG_S3_NO_CHECK_BUCKET=true

firefox_video:
image: selenium/video:ffmpeg-6.1-20240224
@@ -93,6 +95,7 @@ services:
- RCLONE_CONFIG_S3_ACCESS_KEY_ID=${GS_ACCESS_KEY_ID}
- RCLONE_CONFIG_S3_SECRET_ACCESS_KEY=${GS_SECRET_ACCESS_KEY}
- RCLONE_CONFIG_S3_ENDPOINT=https://storage.googleapis.com
- RCLONE_CONFIG_S3_NO_CHECK_BUCKET=true

selenium-hub:
image: selenium/hub:4.18.1-20240224
2 changes: 2 additions & 0 deletions tests/charts/ci/base-recorder-values.yaml
Original file line number Diff line number Diff line change
@@ -24,6 +24,7 @@ videoRecorder:
RCLONE_CONFIG_S3_ACL: "private"
RCLONE_CONFIG_S3_ACCESS_KEY_ID: "${AWS_ACCESS_KEY_ID}"
RCLONE_CONFIG_S3_SECRET_ACCESS_KEY: "${AWS_SECRET_ACCESS_KEY}"
RCLONE_CONFIG_S3_NO_CHECK_BUCKET: "true"
RCLONE_CONFIG_GS_TYPE: "s3"
RCLONE_CONFIG_GS_PROVIDER: "GCS"
RCLONE_CONFIG_GS_ENV_AUTH: "true"
@@ -33,6 +34,7 @@ videoRecorder:
RCLONE_CONFIG_GS_ACCESS_KEY_ID: "${GS_ACCESS_KEY_ID}"
RCLONE_CONFIG_GS_SECRET_ACCESS_KEY: "${GS_SECRET_ACCESS_KEY}"
RCLONE_CONFIG_GS_ENDPOINT: "https://storage.googleapis.com"
RCLONE_CONFIG_GS_NO_CHECK_BUCKET: "true"

ingress-nginx:
controller:
1 change: 1 addition & 0 deletions tests/charts/templates/render/dummy.yaml
Original file line number Diff line number Diff line change
@@ -116,6 +116,7 @@ videoRecorder:
RCLONE_CONFIG_S3_ACL: "private"
RCLONE_CONFIG_S3_ACCESS_KEY_ID: "xxx"
RCLONE_CONFIG_S3_SECRET_ACCESS_KEY: "xxx"
RCLONE_CONFIG_S3_NO_CHECK_BUCKET: "true"

nodeConfigMap:
extraScripts:
1 change: 1 addition & 0 deletions tests/charts/templates/render/dummy_solution.yaml
Original file line number Diff line number Diff line change
@@ -100,6 +100,7 @@ selenium-grid:
RCLONE_CONFIG_S3_ACL: "private"
RCLONE_CONFIG_S3_ACCESS_KEY_ID: "xxx"
RCLONE_CONFIG_S3_SECRET_ACCESS_KEY: "xxx"
RCLONE_CONFIG_S3_NO_CHECK_BUCKET: "true"

nodeConfigMap:
extraScripts:

1 comment on commit 5a23107

@amardeep2006
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I faced this in enterprise environment.

Please sign in to comment.