Reinstate analytics #139
Merged
Reinstate analytics #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickatsegment
requested review from
anastassia-b,
boggsboggs,
eculver and
systemizer
nickatsegment
force-pushed
the
reinstate-analytics
branch
from
b12265b to
d2b17b3
Compare
systemizer
approved these changes
Sep 26, 2018
Contributor
systemizer
left a comment
systemizer
left a comment
There was a problem hiding this comment.
thanks for fixing this!
Closed
systemizer
added a commit
that referenced
this pull request
Sep 27, 2018
This reverts commit 4b62d9e.
systemizer
added a commit
that referenced
this pull request
Sep 27, 2018
Revert "Reinstate analytics (#139)"
systemizer
pushed a commit
that referenced
this pull request
Oct 2, 2018
* add analytics original patch * use gopkg.in to ensure we use v3 of analytics-go * update modules for analytics-go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presumes (incorporates) #138
Vs #136 basically we're just using
gopkg.in. Unfortunately, currently this resolves to an older tag v3.0.0, from 2017/12, but the difference is only release stuff, not source.See also #137