Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up sqs worker templates to Node 16 #862

Merged
merged 7 commits into from
May 13, 2022
Merged

Bump up sqs worker templates to Node 16 #862

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
49acc41
feat: bump up template to node 16
samchungy May 11, 2022
3f8cc41
remove optional parameter
samchungy May 11, 2022
fbf98a8
Create serious-games-study.md
samchungy May 11, 2022
bb5d7e2
Update serious-games-study.md
72636c May 11, 2022
88573e4
feat: bump up cdk template to 16
samchungy May 13, 2022
28e8fa1
refactor: add missing skuba dependency
samchungy May 13, 2022
5b66395
fix: update snapshot
samchungy May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/serious-games-study.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"skuba": patch
---

template/lambda-sqs-worker: Bump up node version to 16
2 changes: 1 addition & 1 deletion template/lambda-sqs-worker/.nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
14
16
2 changes: 1 addition & 1 deletion template/lambda-sqs-worker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# syntax=docker/dockerfile:1.2

FROM node:14-alpine AS dev-deps
FROM node:16-alpine AS dev-deps

WORKDIR /workdir

Expand Down
6 changes: 3 additions & 3 deletions template/lambda-sqs-worker/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,16 @@
"devDependencies": {
"@types/aws-lambda": "^8.10.84",
"@types/chance": "^1.1.3",
"@types/node": "^14.0.0",
"@types/node": "^16.0.0",
"chance": "^1.1.8",
"pino-pretty": "^7.1.0",
"serverless": "^3.0.0",
"serverless": "^3.17.0",
"serverless-plugin-canary-deployments": "^0.8.0",
"serverless-prune-plugin": "^2.0.0",
"skuba": "*"
},
"engines": {
"node": ">=14"
"node": ">=16"
},
"license": "UNLICENSED",
"private": true,
Expand Down
3 changes: 1 addition & 2 deletions template/lambda-sqs-worker/serverless.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,10 @@ provider:
logRetentionInDays: 30
name: aws
region: ap-southeast-2
runtime: nodejs14.x
runtime: nodejs16.x
architecture: arm64
stackName: ${self:service}
stage: ${env:ENVIRONMENT}
versionFunctions: true
Copy link
Contributor Author

@samchungy samchungy May 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is by default true. https://www.serverless.com/framework/docs/providers/aws/guide/functions

deploymentBucket:
# Use a shared account-level bucket for Lambda bundles and other artefacts.
# This is easier to manage in terms of access, deployment, and tagging.
Expand Down