Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ts-node with tsx #1623

Merged
merged 9 commits into from
Sep 2, 2024
Merged

Replace ts-node with tsx #1623

merged 9 commits into from
Sep 2, 2024

Conversation

AaronMoat
Copy link
Contributor

@AaronMoat AaronMoat commented Jul 30, 2024

Completely untested but opening up to early feedback on the principle.

Somewhat tested now, are we happy with major+upgrade at own risk laziness, or are there things we can do to get more confidence?

@AaronMoat AaronMoat requested a review from a team as a code owner July 30, 2024 04:52
Copy link

changeset-bot bot commented Jul 30, 2024

🦋 Changeset detected

Latest commit: 03dd7b2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AaronMoat AaronMoat marked this pull request as draft July 30, 2024 04:54
@AaronMoat AaronMoat marked this pull request as ready for review July 30, 2024 05:21
Copy link
Contributor

@samchungy samchungy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks aight from a quick look

src/cli/node.ts Show resolved Hide resolved
---
'skuba': major
---

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@72636c would you mind wordsmithing this? I'll proceed to merge without significant manual testing in SEEK repos; I hope to be able to get out #1537 as a second major changeset and bundle them in a release, so testing in real repos is likely to be valuable as a combined exercise

@AaronMoat AaronMoat merged commit 95b3888 into main Sep 2, 2024
15 checks passed
@AaronMoat AaronMoat deleted the tsx branch September 2, 2024 00:25
@seek-oss-ci seek-oss-ci mentioned this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants