Check for unused ESLint disable directives (#272)

Author: 72636c

.changeset/green-needles-wait.md

@@ -0,0 +1,12 @@
+---
+'skuba': minor
+---
+
+**lint:** Check for unused `eslint-disable` directives
+
+`skuba lint` will now report on unnecessary `eslint-disable` directives that should be removed:
+
+```diff
+- /* eslint-disable-next-line new-cap */
+const camelCase = 'no problems here';
+```

jest-preset.js

@@ -12,7 +12,6 @@ const TS_JEST_PATH = require.resolve(TS_JEST_NAME);
 
 // Rewrite `ts-jest` transformations using our resolved `TS_JEST_PATH`.
 const tsJestTransform = Object.fromEntries(
-  /* eslint-disable-next-line @typescript-eslint/no-unsafe-member-access */
   Object.entries(tsJestDefaults.transform).map(([key, value]) => [
     key,
     value === TS_JEST_NAME ? TS_JEST_PATH : value,

src/cli/lint.ts

@@ -3,7 +3,7 @@ import { execConcurrently } from '../utils/exec';
 export const lint = () =>
   execConcurrently([
     {
-      command: 'eslint --ext=js,ts,tsx .',
+      command: 'eslint --ext=js,ts,tsx --report-unused-disable-directives .',
       name: 'ESLint',
       prefixColor: 'magenta',
     },

template/koa-rest-api/src/framework/server.test.ts

@@ -225,7 +225,6 @@ describe('createApp', () => {
     const err = chance.sentence();
 
     middleware.mockImplementation(() => {
-      /* eslint-disable-next-line no-throw-literal */
       throw err;
     });