Skip to content

Commit c29c718

Browse files
72636cmiukki
andcommitted
Suggest using a secure header middleware
Co-authored-by: Anja Ishmukhametova <[email protected]>
1 parent 635d4b5 commit c29c718

File tree

3 files changed

+12
-0
lines changed

3 files changed

+12
-0
lines changed

.changeset/rotten-bulldogs-itch.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"skuba": patch
3+
---
4+
5+
template/\*-rest-api: Suggest using a secure header middleware

template/express-rest-api/src/app.ts

+2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ import { healthCheckHandler } from './api/healthCheck';
66
import { smokeTestHandler } from './api/smokeTest';
77

88
const app = express()
9+
// TODO: consider using a middleware that adds secure HTTP headers.
10+
// https://github.com/helmetjs/helmet
911
.get('/health', healthCheckHandler)
1012
.get('/smoke', smokeTestHandler);
1113

template/koa-rest-api/src/framework/server.ts

+5
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import {
44
ErrorMiddleware,
55
MetricsMiddleware,
66
RequestLogging,
7+
// SecureHeaders,
78
VersionMiddleware,
89
} from 'seek-koala';
910

@@ -38,6 +39,10 @@ export const createApp = <State, Context>(
3839
...middleware: Koa.Middleware<State, Context>[]
3940
) =>
4041
new Koa()
42+
// TODO: consider using a middleware that adds secure HTTP headers.
43+
// https://github.com/seek-oss/koala/tree/master/src/secureHeaders
44+
// https://github.com/venables/koa-helmet
45+
// .use(SecureHeaders.middleware)
4146
.use(requestLogging)
4247
.use(metrics)
4348
.use(ErrorMiddleware.handle)

0 commit comments

Comments
 (0)