Avoid alternative syntax for ENV instructions

seek-oss · Mar 30, 2022 · 3ab94f2 · 3ab94f2
1 parent d30f881
commit 3ab94f2
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 7 deletions.
diff --git a/.changeset/six-ladybugs-notice.md b/.changeset/six-ladybugs-notice.md
@@ -0,0 +1,12 @@
+---
+'skuba': patch
+---
+
+template/\*-rest-api: Avoid alternative syntax for ENV instructions
+
+Omitting the `=` symbol in ENV instructions [is discouraged and may be disallowed in future](https://docs.docker.com/engine/reference/builder/#env).
+
+```diff
+- ENV NODE_ENV production
++ ENV NODE_ENV=production
+```
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -113,7 +113,7 @@
   + FROM gcr.io/distroless/nodejs:16 AS runtime
 
   + # https://nodejs.org/api/cli.html#cli_node_options_options
-  + ENV NODE_OPTIONS --enable-source-maps
+  + ENV NODE_OPTIONS=--enable-source-maps
   ```
 
   For a Serverless Lambda application, update your `serverless.yml`:

diff --git a/template/express-rest-api/Dockerfile b/template/express-rest-api/Dockerfile
@@ -25,13 +25,13 @@ COPY --from=build /workdir/lib lib
 
 COPY --from=deps /workdir/node_modules node_modules
 
-ENV NODE_ENV production
+ENV NODE_ENV=production
 
 # https://nodejs.org/api/cli.html#cli_node_options_options
-ENV NODE_OPTIONS --enable-source-maps
+ENV NODE_OPTIONS=--enable-source-maps
 
 ARG PORT=8001
-ENV PORT ${PORT}
+ENV PORT=${PORT}
 EXPOSE ${PORT}
 
 CMD ["lib/listen.js"]
diff --git a/template/koa-rest-api/Dockerfile b/template/koa-rest-api/Dockerfile
@@ -25,13 +25,13 @@ COPY --from=build /workdir/lib lib
 
 COPY --from=deps /workdir/node_modules node_modules
 
-ENV NODE_ENV production
+ENV NODE_ENV=production
 
 # https://nodejs.org/api/cli.html#cli_node_options_options
-ENV NODE_OPTIONS --enable-source-maps
+ENV NODE_OPTIONS=--enable-source-maps
 
 ARG PORT=8001
-ENV PORT ${PORT}
+ENV PORT=${PORT}
 EXPOSE ${PORT}
 
 CMD ["--require", "./lib/tracing.js", "./lib/listen.js"]