Skip to content

Conversation

@carlosthe19916
Copy link
Contributor

@carlosthe19916 carlosthe19916 commented Nov 27, 2025

Migrate the tests located at https://github.com/securesign/rekor-search-ui/blob/main/cypress/e2e/endpoint.cy.ts

As Cypress and Playwright are different tools the code might look like a bit different. However the intention of the test should remain the same

Summary by Sourcery

Migrate Rekor Search endpoint end-to-end tests from Cypress to Playwright and add a test hook to the settings button.

New Features:

  • Introduce Playwright-based end-to-end tests for the Rekor Search endpoint page.

Enhancements:

  • Add a data-testid attribute to the Rekor Search settings button to support reliable end-to-end test selectors.

Tests:

  • Port existing Cypress endpoint tests to Playwright under the Rekor Search page test suite.

@sourcery-ai
Copy link

sourcery-ai bot commented Nov 27, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Migrates Rekor Search endpoint end-to-end tests from Cypress to Playwright and introduces a small UI test hook to support the new tests.

Sequence diagram for Playwright test opening RekorSearch settings

sequenceDiagram
  actor Tester
  participant PlaywrightTest
  participant Browser
  participant RekorSearchPage
  participant SettingsPanel

  Tester->>PlaywrightTest: Run endpoint.spec test
  PlaywrightTest->>Browser: page.goto(/rekor-search)
  Browser->>RekorSearchPage: Render RekorSearch component
  RekorSearchPage->>RekorSearchPage: Render Button with data-testid=settings-button

  PlaywrightTest->>Browser: page.getByTestId(settings-button)
  Browser-->>PlaywrightTest: Return settings-button handle

  PlaywrightTest->>Browser: settings-button.click()
  Browser->>RekorSearchPage: Dispatch click event on settings-button
  RekorSearchPage->>RekorSearchPage: setSettingsOpen(true)
  RekorSearchPage->>SettingsPanel: Mount and display settings UI
  SettingsPanel-->>Tester: Settings visible for assertions
Loading

File-Level Changes

Change Details Files
Expose a stable selector on the Rekor Search settings button for E2E testing.
  • Add a data-testid attribute to the settings button in the Rekor Search header so tests can reliably locate and interact with it
  • Keep existing visual appearance and click behavior (opening settings) unchanged while only extending the component API for tests
client/src/app/pages/RekorSearch/RekorSearch.tsx
Add Playwright end-to-end tests for Rekor Search endpoint behavior, migrated from the previous Cypress test suite.
  • Create a new Playwright spec for the Rekor Search endpoint page under the e2e test hierarchy
  • Reimplement previous Cypress scenarios (navigation, form interaction, search behavior, and settings interactions) using Playwright page APIs and test runners
  • Align test selectors with current UI (including the newly added test id) and any Playwright-specific patterns such as fixtures and expect assertions
e2e/tests/pages/rekor-search/endpoint.spec.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Instead of relying on data-testid="settings-button", consider giving the icon-only settings button an accessible label (e.g. aria-label="Settings") and targeting it via role/name in the Playwright tests to improve both accessibility and selector robustness.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Instead of relying on `data-testid="settings-button"`, consider giving the icon-only settings button an accessible label (e.g. `aria-label="Settings"`) and targeting it via role/name in the Playwright tests to improve both accessibility and selector robustness.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant