-
Notifications
You must be signed in to change notification settings - Fork 0
add ctlog-monitor component #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's GuideThis PR refactors the rekor-monitor Tekton pipelines by renaming its Dockerfile and adjusting trigger expressions, and introduces a new ctlog-monitor component with dedicated pull-request and push pipelines plus its Dockerfile. Flow diagram for ctlog-monitor pipeline triggersflowchart TD
PR["Pull Request Event"] --> CELPR["CEL Expression (ctlog-monitor-pull-request.yaml)"]
CELPR -->|if matched| CMPR["ctlog-monitor-pull-request PipelineRun"]
PUSH["Push Event"] --> CELPU["CEL Expression (ctlog-monitor-push.yaml)"]
CELPU -->|if matched| CMPU["ctlog-monitor-push PipelineRun"]
CMPR --> CMDF["Dockerfile.ctlog-monitor.rh"]
CMPU --> CMDF
CMPR -->|builds| IMGPR["quay.io/securesign/ctlog-monitor:on-pr-{{revision}}"]
CMPU -->|builds| IMGPU["quay.io/securesign/ctlog-monitor:{{revision}}"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The Tekton YAML for both
ctlog-monitorandrekor-monitorpipelines share almost identical on-cel-expression trigger lists—consider extracting or templating this common logic to reduce duplication and drift. - The new
ctlog-monitorcomponent uses mixed naming conventions (hyphens in Dockerfile and pipeline names vs underscores incmd/ct_monitor), so aligning these will avoid confusion and ensure consistency across the repo. - In
ctlog-monitor-push.yaml, thetaskRunTemplateis empty while the pull-request pipeline specifies a service account—verify this is intentional or add the appropriate serviceAccountName for consistent permissions.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The Tekton YAML for both `ctlog-monitor` and `rekor-monitor` pipelines share almost identical on-cel-expression trigger lists—consider extracting or templating this common logic to reduce duplication and drift.
- The new `ctlog-monitor` component uses mixed naming conventions (hyphens in Dockerfile and pipeline names vs underscores in `cmd/ct_monitor`), so aligning these will avoid confusion and ensure consistency across the repo.
- In `ctlog-monitor-push.yaml`, the `taskRunTemplate` is empty while the pull-request pipeline specifies a service account—verify this is intentional or add the appropriate serviceAccountName for consistent permissions.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Add configuration for the ctlog-monitor component alongside updates to the existing rekor-monitor pipelines, including Dockerfile renaming and trigger refinements
New Features:
Enhancements: