Remove unnused methods from Scanner #262
Conversation
| [Obsolete("Should not be part of the Scanner")] | ||
| public bool ReadIdentifier() => ReadIdentifier(out _); | ||
|
|
||
| [Obsolete("Should not be part of the Scanner")] |
There was a problem hiding this comment.
What should be used instead? A note on that would be useful here.
There was a problem hiding this comment.
The parsers already expose Identifier methods.
There was a problem hiding this comment.
I don't understand how that would help here: https://github.com/OrchardCMS/OrchardCore/blob/0b7b4a335e861d50a80f1280fab81f26b0d9d9fb/src/OrchardCore.Modules/OrchardCore.Shortcodes/Controllers/AdminController.cs#L351 Could you please tell?
There was a problem hiding this comment.
Yeah, that's a weird thing to do. This should be provided by the shortcode library. To fix this I would suggest to build an actual shortcode out of the provided name and try to parse it "successfully". My sarcastic mind is glad it exposed bad usages of this ;)
There was a problem hiding this comment.
No description provided.