Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP Archives (PHARs) of PHPUnit 8.5 and PHPUnit 9.6 bundle outdated versions of Prophecy #6071

Closed
oleibman opened this issue Dec 5, 2024 · 2 comments
Closed

PHP Archives (PHARs) of PHPUnit 8.5 and PHPUnit 9.6 bundle outdated versions of Prophecy #6071

oleibman opened this issue Dec 5, 2024 · 2 comments
Assignees
@sebastianbergmann
Labels
feature/prophecy-integration installation/phar type/change-in-php-requires-adaptation A change in PHP requires a change so that existing PHPUnit functionality continues to work version/8 Something affects PHPUnit 8 version/9 Something affects PHPUnit 9

Comments

@oleibman
Copy link

oleibman commented Dec 5, 2024

Q A
PHPUnit version 9.6.21
PHP version 8.4.1
Installation Method PHAR

Summary

Checking some old software for Php8.4 compatibility using 9.6.21 phar. This issue does not arise when I install phpunit 9.6.21 with composer and use it; it is only a problem when using the phar.

Current behavior

Many messages like the following, all pointing to Prophecy:

PHP Deprecated:  Prophecy\Argument\Token\ExactValueToken::__construct(): Implicitly marking parameter $util as nullable is deprecated, the explicit nullable type must be used instead in phar://C:/git/excel - Copy/unitTests/phpunit-9.6.21.phar/phpspec-prophecy/Prophecy/Argument/Token/ExactValueToken.php on line 36

How to reproduce

php8.4 phpunit-9.6.21.phar

Expected behavior

No deprecation messages.
@oleibman oleibman added the type/bug Something is broken label Dec 5, 2024
@sebastianbergmann sebastianbergmann changed the title PhpUnit 9.6.21 Phar Reports Deprecations with Php8.4 in Prophecy PHP Archives (PHARs) of PHPUnit 8.5 and PHPUnit 9.6 bundle outdated versions of Prophecy Dec 5, 2024
@sebastianbergmann sebastianbergmann self-assigned this Dec 5, 2024
@sebastianbergmann sebastianbergmann added feature/prophecy-integration installation/phar type/change-in-php-requires-adaptation A change in PHP requires a change so that existing PHPUnit functionality continues to work version/9 Something affects PHPUnit 9 version/8 Something affects PHPUnit 8 and removed type/bug Something is broken labels Dec 5, 2024
@sebastianbergmann
Copy link
Owner

PHPUnit 8.5.41 and PHPUnit 9.6.22 have been released. The PHP Archives (PHARs) for these versions contain a version of Prophecy that is compatible with PHP 8.4.

@oleibman
Copy link
Author

oleibman commented Dec 5, 2024

Thank you for taking care of this so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastianbergmann sebastianbergmann

Labels
feature/prophecy-integration installation/phar type/change-in-php-requires-adaptation A change in PHP requires a change so that existing PHPUnit functionality continues to work version/8 Something affects PHPUnit 8 version/9 Something affects PHPUnit 9
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebastianbergmann @oleibman