Fix issues identified by Psalm

sebastianbergmann · Mar 25, 2020 · fb668be · fb668be
1 parent 0314d1b
commit fb668be
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/src/Framework/MockObject/Rule/MethodName.php b/src/Framework/MockObject/Rule/MethodName.php
@@ -25,21 +25,20 @@ final class MethodName
     private $constraint;
 
     /**
-     * @param  Constraint|string
+     * @param Constraint|string $constraint
      *
-     * @throws Constraint
-     * @throws \PHPUnit\Framework\Exception
+     * @throws InvalidArgumentException
      */
     public function __construct($constraint)
     {
-        if (!$constraint instanceof Constraint) {
-            if (!\is_string($constraint)) {
-                throw InvalidArgumentException::create(1, 'string');
-            }
-
+        if (\is_string($constraint)) {
             $constraint = new MethodNameConstraint($constraint);
         }
 
+        if (!$constraint instanceof Constraint) {
+            throw InvalidArgumentException::create(1, 'PHPUnit\Framework\Constraint\Constraint object or string');
+        }
+
         $this->constraint = $constraint;
     }