Closes #6368

Author: sebastianbergmann

ChangeLog-10.5.md

@@ -2,6 +2,12 @@
 
 All notable changes of the PHPUnit 10.5 release series are documented in this file using the [Keep a CHANGELOG](https://keepachangelog.com/) principles.
 
+## [10.5.58] - 2025-MM-DD
+
+### Fixed
+
+* [#6368](https://github.com/sebastianbergmann/phpunit/issues/6368): `failOnPhpunitWarning="false"` has no effect
+
 ## [10.5.57] - 2025-09-24
 
 * No changes; `phpunit.phar` rebuilt with updated dependencies
@@ -492,6 +498,7 @@ All notable changes of the PHPUnit 10.5 release series are documented in this fi
 
 * [#5563](https://github.com/sebastianbergmann/phpunit/issues/5563): `createMockForIntersectionOfInterfaces()` does not automatically register mock object for expectation verification
 
+[10.5.58]: https://github.com/sebastianbergmann/phpunit/compare/10.5.57...10.5
 [10.5.57]: https://github.com/sebastianbergmann/phpunit/compare/10.5.56...10.5.57
 [10.5.56]: https://github.com/sebastianbergmann/phpunit/compare/10.5.55...10.5.56
 [10.5.55]: https://github.com/sebastianbergmann/phpunit/compare/10.5.54...10.5.55

src/TextUI/ShellExitCodeCalculator.php

@@ -27,7 +27,7 @@ public function calculate(Configuration $configuration, TestResult $result): int
     {
         $failOnDeprecation        = false;
         $failOnPhpunitDeprecation = false;
-        $failOnPhpunitWarning     = true;
+        $failOnPhpunitWarning     = false;
         $failOnEmptyTestSuite     = false;
         $failOnIncomplete         = false;
         $failOnNotice             = false;
@@ -38,6 +38,7 @@ public function calculate(Configuration $configuration, TestResult $result): int
         if ($configuration->failOnAllIssues()) {
             $failOnDeprecation        = true;
             $failOnPhpunitDeprecation = true;
+            $failOnPhpunitWarning     = true;
             $failOnEmptyTestSuite     = true;
             $failOnIncomplete         = true;
             $failOnNotice             = true;
@@ -62,6 +63,10 @@ public function calculate(Configuration $configuration, TestResult $result): int
             $failOnPhpunitDeprecation = false;
         }
 
+        if ($configuration->failOnPhpunitWarning()) {
+            $failOnPhpunitWarning = true;
+        }
+
         if ($configuration->doNotFailOnPhpunitWarning()) {
             $failOnPhpunitWarning = false;
         }

tests/end-to-end/regression/6368.phpt

@@ -0,0 +1,36 @@
+--TEST--
+https://github.com/sebastianbergmann/phpunit/issues/6368
+--FILE--
+<?php declare(strict_types=1);
+$_SERVER['argv'][] = '--do-not-cache-result';
+$_SERVER['argv'][] = '--debug';
+$_SERVER['argv'][] = '--configuration';
+$_SERVER['argv'][] = __DIR__ . '/6368/phpunit.xml';
+
+require_once __DIR__ . '/../../bootstrap.php';
+
+(new PHPUnit\TextUI\Application)->run($_SERVER['argv']);
+--EXPECTF--
+PHPUnit Started (PHPUnit %s using %s)
+Test Runner Configured
+Test Suite Loaded (1 test)
+Event Facade Sealed
+Test Runner Started
+Test Suite Sorted
+Test Runner Execution Started (1 test)
+Test Suite Started (%sphpunit.xml, 1 test)
+Test Suite Started (default, 1 test)
+Test Suite Started (PHPUnit\TestFixture\Issue6368\Issue6368Test, 1 test)
+Test Preparation Started (PHPUnit\TestFixture\Issue6368\Issue6368Test::testOne)
+Test Prepared (PHPUnit\TestFixture\Issue6368\Issue6368Test::testOne)
+Test Runner Triggered Warning (message)
+Test Triggered PHPUnit Warning (PHPUnit\TestFixture\Issue6368\Issue6368Test::testOne)
+message
+Test Passed (PHPUnit\TestFixture\Issue6368\Issue6368Test::testOne)
+Test Finished (PHPUnit\TestFixture\Issue6368\Issue6368Test::testOne)
+Test Suite Finished (PHPUnit\TestFixture\Issue6368\Issue6368Test, 1 test)
+Test Suite Finished (default, 1 test)
+Test Suite Finished (%sphpunit.xml, 1 test)
+Test Runner Execution Finished
+Test Runner Finished
+PHPUnit Finished (Shell Exit Code: 0)

tests/end-to-end/regression/6368/phpunit.xml

@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:noNamespaceSchemaLocation="../../../../phpunit.xsd"
+         failOnPhpunitWarning="false"
+>
+    <testsuites>
+        <testsuite name="default">
+            <directory>tests</directory>
+        </testsuite>
+    </testsuites>
+</phpunit>

tests/end-to-end/regression/6368/tests/Issue6368Test.php

@@ -0,0 +1,24 @@
+<?php declare(strict_types=1);
+/*
+ * This file is part of PHPUnit.
+ *
+ * (c) Sebastian Bergmann <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+namespace PHPUnit\TestFixture\Issue6368;
+
+use PHPUnit\Event\Facade as EventFacade;
+use PHPUnit\Framework\Attributes\DoesNotPerformAssertions;
+use PHPUnit\Framework\TestCase;
+
+final class Issue6368Test extends TestCase
+{
+    #[DoesNotPerformAssertions]
+    public function testOne(): void
+    {
+        EventFacade::emitter()->testRunnerTriggeredPhpunitWarning('message');
+        EventFacade::emitter()->testTriggeredPhpunitWarning($this->valueObjectForEvents(), 'message');
+    }
+}