Wrap helper callback in an autoloaded wrapper to keep namespace clean

sebastianbergmann · Dec 24, 2018 · d0e22b0 · d0e22b0
1 parent 3f9ef97
commit d0e22b0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/tests/_files/FunctionCallback.php b/tests/_files/FunctionCallback.php
@@ -7,11 +7,14 @@
  * For the full copyright and license information, please view the LICENSE
  * file that was distributed with this source code.
  */
-function functionCallback()
+class FunctionCallbackWrapper
 {
-    $args = \func_get_args();
+    public static function functionCallback()
+    {
+        $args = \func_get_args();
 
-    if ($args == ['foo', 'bar']) {
-        return 'pass';
+        if ($args == ['foo', 'bar']) {
+            return 'pass';
+        }
     }
 }
diff --git a/tests/unit/Framework/MockObject/MockObjectTest.php b/tests/unit/Framework/MockObject/MockObjectTest.php
@@ -272,7 +272,7 @@ public function testFunctionCallback(): void
 
         $mock->expects($this->once())
              ->method('doSomething')
-             ->will($this->returnCallback('functionCallback'));
+             ->will($this->returnCallback('FunctionCallbackWrapper::functionCallback'));
 
         $this->assertEquals('pass', $mock->doSomething('foo', 'bar'));
 
@@ -282,7 +282,7 @@ public function testFunctionCallback(): void
 
         $mock->expects($this->once())
              ->method('doSomething')
-             ->willReturnCallback('functionCallback');
+             ->willReturnCallback('FunctionCallbackWrapper::functionCallback');
 
         $this->assertEquals('pass', $mock->doSomething('foo', 'bar'));
     }