From bf0010f4edf4f0a49cbd3c216847fd740b2a15c4 Mon Sep 17 00:00:00 2001 From: Sebastian Bergmann Date: Mon, 28 Oct 2019 08:38:26 +0100 Subject: [PATCH] Fix CS/WS issues --- src/Util/Filter.php | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/src/Util/Filter.php b/src/Util/Filter.php index d17059258e1..7fd8050499a 100644 --- a/src/Util/Filter.php +++ b/src/Util/Filter.php @@ -75,26 +75,23 @@ private static function shouldPrintFrame($frame, $prefix, Blacklist $blacklist): $fileIsNotPrefixed = $prefix === false || \strpos($file, $prefix) !== 0; $script = \realpath($GLOBALS['_SERVER']['SCRIPT_NAME']); - return \is_file($file) - && self::fileIsBlacklisted($file, $blacklist) - && $fileIsNotPrefixed - && $file !== $script; + return \is_file($file) && + self::fileIsBlacklisted($file, $blacklist) && + $fileIsNotPrefixed && + $file !== $script; } - private static function fileIsBlacklisted($file, Blacklist $blacklist) + private static function fileIsBlacklisted($file, Blacklist $blacklist): bool { - return ( - empty($GLOBALS['__PHPUNIT_ISOLATION_BLACKLIST']) - || !\in_array($file, $GLOBALS['__PHPUNIT_ISOLATION_BLACKLIST']) - ) - && !$blacklist->isBlacklisted($file); + return (empty($GLOBALS['__PHPUNIT_ISOLATION_BLACKLIST']) || + !\in_array($file, $GLOBALS['__PHPUNIT_ISOLATION_BLACKLIST'], true)) && + !$blacklist->isBlacklisted($file); } private static function frameExists(array $trace, string $file, int $line): bool { foreach ($trace as $frame) { - if (isset($frame['file']) && $frame['file'] === $file && - isset($frame['line']) && $frame['line'] === $line) { + if (isset($frame['file'], $frame['line']) && $frame['file'] === $file && $frame['line'] === $line) { return true; } }