Optimised tight cycle in `PHPUnit\Util\Test#parseTestMethodAnnotation…

…s()` This method is used very often (10k+ times in a small test suite), so it needs to be quite efficient, if possible.
sebastianbergmann · Sep 7, 2019 · 878e34e · 878e34e
1 parent fe308f3
commit 878e34e
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/src/Util/Test.php b/src/Util/Test.php
@@ -306,14 +306,14 @@ public static function getProvidedData(string $className, string $methodName): ?
 
     public static function parseTestMethodAnnotations(string $className, ?string $methodName = ''): array
     {
+        $registry = Registry::singleton();
+
         if ($methodName !== null) {
             try {
                 return [
-                    'class' => Registry::singleton()
-                        ->forClassName($className)
+                    'method' => $registry->forMethod($className, $methodName)
                         ->symbolAnnotations(),
-                    'method' => Registry::singleton()
-                        ->forMethod($className, $methodName)
+                    'class'  => $registry->forClassName($className)
                         ->symbolAnnotations(),
                 ];
             } catch (Exception $methodNotFound) {
@@ -322,10 +322,9 @@ public static function parseTestMethodAnnotations(string $className, ?string $me
         }
 
         return [
-            'class' => Registry::singleton()
-                ->forClassName($className)
-                ->symbolAnnotations(),
             'method' => null,
+            'class'  => $registry->forClassName($className)
+                ->symbolAnnotations(),
         ];
     }