Corrected type declarations around `PHPUnit\Framework\TestCase#(get|s…

…et)Tests` parameters These were supposed to be `TestCase` rather than more generic `Test` instances.
sebastianbergmann · Sep 7, 2019 · 74f1bc4 · 74f1bc4
1 parent cf1e222
commit 74f1bc4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/Framework/TestSuite.php b/src/Framework/TestSuite.php
@@ -617,7 +617,7 @@ public function testAt(int $index)
     /**
      * Returns the tests as an enumeration.
      *
-     * @return Test[]
+     * @return TestCase[]
      */
     public function tests(): array
     {
@@ -627,7 +627,7 @@ public function tests(): array
     /**
      * Set tests of the test suite
      *
-     * @param Test[] $tests
+     * @param TestCase[] $tests
      */
     public function setTests(array $tests): void
     {

diff --git a/src/Runner/TestSuiteSorter.php b/src/Runner/TestSuiteSorter.php
@@ -361,6 +361,10 @@ private function cmpSize(Test $a, Test $b): int
      * @param array<DataProviderTestSuite|TestCase> $tests
      *
      * @return array<DataProviderTestSuite|TestCase>
+     *
+     * @psalm-template T of array<DataProviderTestSuite|TestCase>
+     * @psalm-param    T $tests
+     * @psalm-return   T
      */
     private function resolveDependencies(array $tests): array
     {