-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
update meta to properly infer type of string parameters
- Loading branch information
1 parent
f434a4d
commit 7062932
Showing
1 changed file
with
6 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7062932
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isfedorov , this notation looks different to what is documented at https://www.jetbrains.com/help/phpstorm/ide-advanced-metadata.html#map which uses
@
to represent the function argument value. Is this new?7062932
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmewburn That's because the new format isn't documented yet, but this task is on track. Please see comments in https://youtrack.jetbrains.com/issue/WI-60544 for details.
7062932
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @isfedorov . What about the members of
\PHPUnit\Framework\MockObject\MockObject
? Won't these be lost because the type is just inferred as$0
, ie the arg value?7062932
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmewburn Not sure if I've got your question right. Type will be inferred as
MockObjet|<TypeFromStringParameter>
thus all members of those classes will be available