Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticker height in add-on bar #23

Open
0uk opened this issue Aug 24, 2017 · 4 comments
Open

ticker height in add-on bar #23

0uk opened this issue Aug 24, 2017 · 4 comments

Comments

@0uk
Copy link

0uk commented Aug 24, 2017

Hi and thanks for this bitcoin price ticker add-on.

I have a problem when inserting tickers in an add-on bar (such as the new add-on bar). Indeed, I can only see half of each ticker because the height is fixed to the URL bar height:

image

Would you know if it would be possible to add a 'widget height' option ? or, even better, to make the widget automatically fit in the bar it is added to ?

Thanks again!

@sebaslogen
Copy link
Owner

Interesting add-on, I haven't heard of it before, I'll take a look.

Nevertheless, this add-on will stop working in about two months so this problem won't probably be fixed on time. For more info see comment: #22 (comment)

@0uk
Copy link
Author

0uk commented Aug 24, 2017

Yes I'm aware of all the Firefox 57 'upgrades' regarding plugins. Given the number of great plugins that cannot be upgraded I have the feeling I'll stick with v56 for a while, so your plugin won't stop working in 2 months on my computer!

@sebaslogen
Copy link
Owner

I just tried the bar on my Firefox and it looks good although the tickers are aligned to bottom instead of being vertically centered in the "new add-on bar".

Have you tried reducing the font size of the tickers? There is an option at the top of the settings page of this addon

@0uk
Copy link
Author

0uk commented Aug 24, 2017

Yes I forgot to mention I tried that first, and the top margin is unaffected. At some point in the past the tickers were aligned at the bottom indeed (which was not an issue), but for some reason they are now half-hidden. Changing the theme does nothing either ...

image

Actually the only way to make the numbers relatively visible is to increase the font size to 18 (above it looks like it triggers an infinite resize loop and the width keeps growing until only the leftmost ticker is visible).

I tried to hack in the code to see if changing some parameters affected the display but could not make it work (it resulted in the add-on being disabled as FF could no longer validate it as changes were made in the xpi archive).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants