Repository navigation
Token tooling repairs for the GPT-6 findings on #289/#297/#300/#303: probe exit status and lifecycle, context-mode Codex binding, retained coverage evidence - #333
Merged
seathatflowsinourveins merged 1 commit intoSep 26, 2026
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
seathatflowsinourveins
deleted the
claude/token-tooling-review-fixes-pr-20260926
branch
September 26, 2026 11:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR repairs the GPT-6 cross-family findings on merged #289, #297, #300 and #303, the token-efficiency wiring and coverage check, and retains the evidence behind them. Numbers below come from the committed artifacts.
cwd ".", which Codex resolves against the plugin root. The server then chose the newest Codex session log's worktree, not the session's own.adoption/templates/codex.config.template.tomlregisters[mcp_servers.context-mode]at user scope with nocwd. It runs the pinned upstreamstart.mjswithCONTEXT_MODE_PLATFORM=codexand disables the plugin's own server while keeping its hooks and skills.evidence/artifacts/context-mode-codex-binding-20260926/results.json, a local integration check across real servers answeringctx_execute pwd, the plugin form bound 2 of 4 sessions and the bare CLI 2 of 4, while the repaired user-scopestart.mjsform bound 4 of 4.upstream-resolver-tests.txt).scripts/adoption_status.py --pinned-versionscounts a version match only when the probe exits 0.SIG_DFL, sonohupand background jobs keep an inheritedSIG_IGN.Popenuntil the group is killed and reaped. A test injects an interrupt at the start of every line the probe runs.tests/test_adoption_status.pynow has 72 tests. The failing-first controls are retained underevidence/artifacts/token-coverage-20260926/.evidence/artifacts/token-coverage-20260926/holds the coverage runs with provenance, plus a failing wiring control. With an emptyCODEX_HOME, the run reportscomplete: false. Statements that were never retained are marked as such.HF_HUB_OFFLINE=1andTRANSFORMERS_OFFLINE=1next toHEADROOM_OFFLINEandDO_NOT_TRACK. The decision addendum states that tiktoken'so200k_basestill downloads on a cold cache (bounded byHEADROOM_TIKTOKEN_LOAD_TIMEOUT_SECONDS).blueprints/memory-lifecycle-v2/README.md, which saysstack.jsonpins 2.4.1 and the landscape winner stays 2.3.2.lane:shareddashboard PR.New-machine inputs change here (
scripts/adoption_status.pyand the Codex templates). Each doc unit that describes the changed behaviour carries a "changed afterv2026.09.26" marker.Review
Popen), fixed at both ends, plus 1 low (a per-request deadline inbinding_check.py), also fixed. The as-run original is kept asbinding_check.original.py.Residuals
scripts/adoption_status.py(sha2562b372896…). The last runs used earlier revisions, and the later changes affect only an interrupted probe, which the unit tests and the retained every-line control cover.binding_check.pyafter the deadline fix has not been re-run against real servers. The retained results came frombinding_check.original.py.Verification
scripts/validate.py,host_receipts.py validate,component_matrix.py --check,new_host_grand_list.py --check,evidence_manifest.py --checkandvalidate_catalogs.py: all pass.python -m unitteston this change before its final replay onto main:Ran 6058 tests,OK (skipped=635). After the replay, the related modules and every validator were re-run and pass.SOTA sources
mcp_servers,cwd, per-plugin server overrides): https://developers.openai.com/codex/mcp and https://github.com/openai/codex/blob/rust-v0.155.1/codex-rs/core/src/plugin_config.rssubprocess.Popen(start_new_session=True)andsignal: https://docs.python.org/3/library/subprocess.html#popen-constructor and https://docs.python.org/3/library/signal.htmlHF_HUB_OFFLINE,TRANSFORMERS_OFFLINE): https://huggingface.co/docs/huggingface_hub/package_reference/environment_variables🤖 Generated with Claude Code