Repository navigation
fix: withhold private child-usage authentication and pair extras - #1032
seathatflowsinourveins wants to merge 5 commits into
Conversation
a52e89e to
e130a75
Compare
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
e130a75 to
7a4c7db
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Scope
Withhold private raw-output authentication from 12 published child-usage receipts and preserve the six frozen ledger bindings through the CC-ruled append-only
redaction-supersessionkind. The landed #995 writer is preserved unchanged; its published pair allowlist contains labels and the two agent IDs, with native keys local. Original sweep records, policy, votes and counters are unchanged.The previous migration gate is resolved by option (b). Six records appended through the native ledger command bind each original published Git blob to its redacted successor. Both immutable history and current registered bytes are verified; no append-only check or publication guard is bypassed.
489b263286edd87493689347a5411b263d60e306, including landed Apply verified event scopes to CI secret scans #949, fix(landscape): bind completed supersessions and redact scratch sessions #995 and Finalize 373 starred repositories with guarded retention and source coverage #1016.421bf3f98b631d931838c22a927b4fec246f7df8.lane:foundation.429f0421; Apply verified event scopes to CI secret scans #949 and Finalize 373 starred repositories with guarded retention and source coverage #1016 advisory appends are on the current base. The PR remains a draft until the co-op verifies the adapted head.SOTA sources
proven_supersessions, and nativesweep_common.pyjson_text: use the existing validated pair fields and exact published proof serialization.Checker,append,record_sha256,write_ledger,check_append_only: this extends its existing record chain and native atomic writer. The unchanged-prefix checker and re-chained-rewrite regression are preserved exactly.git cat-filechecks the historical source object is a commit, andgit showresolves the immutablecommit:pathblob, following the ledger's existing pinned-history mechanism. Lazy fetching and optional locks are disabled during verification; missing history fails closed.Evidence-class table
--appendbatch,--check --base, independent unchanged-sweep comparisonHistorical local commands at the original review head
The first broad development run exposed schema, seed re-derivation and a no-model-client token-name mismatch. Those were corrected. The original failure is retained, and final broader-suite results are reported in FIX-PUSHED. Seed re-derivation explicitly accounts for a checked redaction binding while preserving every historical semantic field; it does not rewrite the seed. The original append-only checker and rechain regression source are unchanged.
Decision record
docs/decisions/2026-10-12-child-usage-publication-privacy.md; native kind and appender documentation incatalogs/saturation/README.md.The newest binding authenticates current bytes. Every predecessor must resolve to the named full Git commit/path and match the stored digest. For this #161 kind, receipt JSON may differ only by the private raw-authentication marker. An atomic batch validates the whole proposed ledger before writing; an unrelated broken record, registration or lineage still refuses. Redaction records contain no date, run, vote or layer and cannot count as a fresh sweep.
Historical receipt blobs remain in immutable published Git history, the residual the CC explicitly ruled equivalent to #177. The new digest bindings authenticate those already-published Git preimages; they do not publish the private raw-output preimage or its original digest anew.
Host evidence
No host receipt, platform-status or live configuration change. Original private authentication remains in host state.
Follow-ups
Checklist
--check --baseand the original rechain guard remain unchanged and pass.Adapted rebase after the append chain
Previously reviewed content head e130a75 was rebased onto main 7151664. Its pure registry-rebase equivalent is 7a4c7db on main 489b263. The original public input and history bindings remain unchanged. Three receipt/ledger/whitespace commits replayed, then ONE dated native advisory commit appended after #949 and #1016. The original read head a52e89e is superseded only by the exact leased push.
Beyond pure replay from a52e89e: preserve landed #995's entire usage_record.py, removing the obsolete five-field pair projection; adapt the retained CLI regression to its three public fields; qualify that change and cite landed #995 in the sweep record. Re-register evidence natively over main. The writer README, postrun tests and workflow SHA256SUMS are byte-identical to current main. Ledger implementation/tests/history and F3 whitespace carry are unchanged outside inherited patch context.
The ordered new advisory entry reuses native GitTree/derive_ci_protected at committed 07be055. It derives 346 reads against the unchanged #1016 baseline, with two extra saturation-ledger reads, exact script/shape/location differences and permission_change false. No historical delta or baseline is rewritten. Source: blueprints/runtime-workers/openhands/evidence/advisory-gate-deltas.md at 7151664; its cited native Git/CPython mechanisms are reused without changing the resolver gate.
Historical bounded checks at reviewed content head e130a75:
Carried review Follow-ups
The permanent GSD binding regression belongs to #1031 under the later CC ruling, so no #1031 test or source-intake scope is added to this PR. W7 S1 batches remain parked.
Tests-only fixture publication correction
Head 93c1854 adds ONE tests-only correction commit on 7a4c7db; production writer, ledger, receipt bytes, history bindings and advisory accounting are unchanged.
Both the added and inherited Git identity literals in the changed ledger test are replaced with a fixed non-email fixture placeholder. The previous reserved-domain strings were synthetic and do not establish a real-address leak; this correction follows the repository publication rule. No address literal is repeated in this body or the new regression.
The new whole-ledger-test publication guard fails on exact 7a4c7db source (1 test / 1 failure / exit 1; two disallowed literals) and passes after the fix. It distinguishes the documented no-reply domain exception while requiring the current fixtures to publish no email-shaped literal. All three child-usage publication tests and all 106 ledger tests pass, including the historical commit/rechain and redaction controls. Native validator and evidence registration checks pass; only the two changed test registrations are refreshed.
Primary source: installed Git 2.53.0, git/git@67ad421, Documentation/config/user.adoc:1-12 documents that command-scoped user.name/user.email determine author/committer metadata. The unchanged native Git fixture path reproduces successful commits with the non-email placeholder. The repository unittest harness executes the red/green publication guard; no new scanner, decoder or runtime mechanism is introduced.
Astra fix2 Follow-ups (ACK at 93c1854)
The PR stays draft/class 4. The CC tests-only check and Astra's correction delta await class-1/2 capacity. W7 S1 batches remain parked.
Astra fix2 at 93c1854 is ACK with zero blockers. The head stays frozen for the CC class-4 Claude check; no further commit or push is owed without a CC request.