Repository navigation
Preserve missing-vote candidates in final-stack survivors - #1026
seathatflowsinourveins merged 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1916274b77
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1916274 to
5f6c068
Compare
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Scope
Preserve unresolved candidates when a sweep's only refutation is a missing return, using the existing native ledger classifier. Cache parsed vote documents once per build, and treat a later covering sweep's missing-vote-only re-proposal as reopening an earlier refutation, as ruled for Chandra.
5f6c068a9650c0df0c907483f5536931fbcb10ca.8b1ef0c37e2f523aa84d2c75960540f45e74e814; lane:lane:foundation.1916274bwas replayed as50e10f77fed7b6107ea6f622af904e58760e2f14; ONE correction follows that rebased tip.SOTA sources
refutes_on_merit,refuted_by_absence,ref_resolverat 657–658, andChecker.documentat 733–736. Follow its existing per-path parsed-document cache pattern, retaining safe loading and first-read source hashes. The classifier/resolver are unchanged.Evidence-class table
synthetic,local_integrationsynthetic,local_integrationlocal_integrationlocal_integrationlocal_integrationnative_provenLocal commands run
Generated fields and rebase
The original correction restores 21 survivors. The CC's Chandra ruling adds one more: document-retrieval 12 → 13, overall 106 → 107, dated at its 2026-09-29 re-proposal. A prior survivor such as Exa retains its existing provenance. A missing entry without a later re-proposal does not reopen a refutation.
Against the rebased reviewed tip, changes are the Chandra survivor, document-retrieval surviving/refuted funnel counts, its repository index role, summary count and the corresponding definitions. Runs, winners, statuses and source bindings remain unchanged by the correction. The rebase carries main's updated skills-lifecycle source hash. The report is 309,186 bytes, SHA256
5dde8ad61bb124fbcb2d56acb6c0973febc0802fda54bf5e5d8127ce9c15153b.Rebase range-diff shows one
=outside the evidence registry. Native stable patch IDs from zero-context diffs also match outside that registry; the full range-diff differs only in the recomputed report binding. Main's 11,738 evidence entries and non-file records are retained; only the three owned bindings change and match actual bytes.Decision record and thread disposition
The existing protocol and the CC's 2026-10-12 adjudication govern this correction. Codex thread
PRRT_kwDOUg_LrM6rTSKsidentifies the reproduced caching defect; it has been replied to with the fix and resolved. The correction uses a build-scoped parsed-document cache and keeps the existing vote resolver/classifier. The regression verifies one read per document per build, including a second build with an independent cache and matching source hash. Chandra's separate fail-first fixture covers a prior substantive lens refutation followed by a missing-only re-proposal.Follow-ups
extra/, or explicitly designate their authenticated tree/Git blobs as retained source copies; published bytes were verified, while original capture provenance remains unverified.Validator.documentto the pinnedChecker.document; the cited per-path cache implementation and code behavior are unchanged.Host evidence and checklist
No host receipts or platform statuses change. Fixture and build measurements establish repository integration, not provider/GPU/adoption or vendor-harness acceptance. Astra ACK and Claude CHANGES_REQUESTED at 1916274 are recorded; their delta confirmations at 5f6c068 are Astra ACK and Claude micro PASS_WITH_P3.
ONE exact-1916274b leased push returns 0. Native pre-push scans 12,537 files with zero host matches; three registry tests pass in 0.267s and one published-digest privacy test passes in 12.951s. Main advanced after the rebase; read-only merge-tree against observed
421bf3f98b631d931838c22a927b4fec246f7df8is clean, but local acceptance is pinned to the rebased main above.Follow-ups after landing
Landed at 2f79ae7 on 2026-10-12T13:51:33Z from head 5f6c068 (Claude micro PASS_WITH_P3, GPT read ACK; Codex unavailable at its usage limit). The Follow-ups listed above carry forward unchanged; none blocks.