Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dataproviders module functions including deprecating getFeatures for getDatasourceFeatures #384

Merged
merged 10 commits into from
Dec 12, 2024

Conversation

twelch
Copy link
Contributor

@twelch twelch commented Dec 10, 2024

Breaking changes:

  • Drop genClipLoader, replaced with clipToPolygonFeatures/genClipToPolygonFeatures and clipToPolygonDatasources/genClipToPolygonDatasources. Users on upgrade should look at preprocessing functions now installed with new project and borrow their code.

Other changes:

  • drop global datasources from base-project. No longer included with new project.
  • loadFgb: add retry on error with exponential backoff
  • Deprecate getFeatures (in name) and replace with same functionality in getDatasourceFeatures. This makes it clear that this is a datasource aware function.
  • getDatasourceFeatures - accept sketch option switch to use getFeaturesForSketchBBoxes
  • getFeaturesForSketchBBoxes - support all geometry types and add generics support, add lower-level getFeaturesForBBoxes
  • contribute squares.fgb, squares.json and update squareSketches fixtures for testing along with ascii art squaresReadme.txt for seeing the polygons to know how to use. Develop getFeaturesForSketchBBoxes e2e tests to use them.

ToDo:

  • Update code and tutorials to pass type when using getFeaturesForSketchBBoxes

Resolves #386

getDatasourceFeatures - accept sketch option and use getFeaturesForSketchBBoxes
getFeaturesForSketchBBoxes - improve typing and docs, add lower-level getFeaturesForBBoxes
Drop genClipLoader
@twelch twelch changed the title Get features and friends Refactor dataproviders module functions including deprecating getFeatures for getDatasourceFeatures Dec 10, 2024
@twelch twelch marked this pull request as ready for review December 10, 2024 06:30
@twelch twelch merged commit 3622f07 into dev Dec 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorporate getFeaturesForSketchBBoxes into getFeatures?
1 participant