Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook must be restored to updating example result values #374

Open
underbluewaters opened this issue Nov 22, 2024 · 3 comments
Open
Milestone

Comments

@underbluewaters
Copy link
Collaborator

I'm finding myself discovering errors or changes I'd like to make to geoprocessing function results after reviewing them in Storybook. Re-running the tests and generating new example results does not appear to update the storybook output, either via hot-reload or a manual refresh. I'm having to restart Storybook entirely.

@twelch
Copy link
Contributor

twelch commented Nov 22, 2024

This is a known issue (to me anyway) with storybook losing it's storiesOf functionality in the latest version 8. Their proposed methods for migrating (using the indexer) felt too low-level and undocumented for me to figure out 6 months ago. I figured the community would come up with a higher-level solution.

So I punted (for now) and created genReportStories script as a user-space solution, which has the downsides you mention. You have to regenerate the stories manually on storybook startup. Maybe there's a way to trigger the regeneration in user-space outside of storybook, or maybe there's a solution out there now that better hooks into storybook.

storybookjs/storybook#23177

@twelch
Copy link
Contributor

twelch commented Nov 22, 2024

There was a lot of complaints about this breaking change, and I was not the only one to choose the solution I did.

@twelch
Copy link
Contributor

twelch commented Nov 22, 2024

I used the latest version 8 of storybook because it gave the needed Vite support as the builder, and best shot of working out of the box in an esm node environment.

@twelch twelch added this to the 7.1 milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants