Delete chunked cache results on clear:results #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@avmey can you give a little info on what was happening and how this is the fix for it? Thanks! |
|
@twelch Updated the original description. Let me know if you need any more description! |
twelch
approved these changes
Dec 12, 2024
|
Looks good, thanks for the explanation and fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #366
When the user ran
clear:resultsand specified a report, i.e.depth, current behavior is to pull down all cached results with the servicedepthto delete. This works when cached results are small enough that they only require one cache table entry. When cached results are larger, the results are split over multiple entries in chunks and the service named becomesdepth-chunk-0,depth-chunk-1, etc.Now
clear:resultswill select items from the cache table with an exact match (depth) AND chunked results (depth-chunk*)