Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe check for empty proxy env variables #1422

Closed
vsaase opened this issue Jan 5, 2022 · 1 comment
Closed

Maybe check for empty proxy env variables #1422

vsaase opened this issue Jan 5, 2022 · 1 comment
Labels
E-easy Effort: Easy! Start here :D E-pr-welcome The feature is welcome to be added, instruction should be found in the issue.

Comments

@vsaase
Copy link
Contributor

vsaase commented Jan 5, 2022

reqwest/src/proxy.rs

Line 804 in d4986e5

fn insert_from_env(proxies: &mut SystemProxyMap, scheme: &str, var: &str) -> bool {

I ran into an issue were I mistakenly did export http_proxy= as someone on the StackOverflow suggested, instead of unset http_proxy. This caused an RelativeUrlWithoutBase error. Maybe you want to check for empty strings here?
@seanmonstar
Copy link
Owner

Sure, sounds like a good idea. Want to submit a PR?

@seanmonstar seanmonstar added E-easy Effort: Easy! Start here :D E-pr-welcome The feature is welcome to be added, instruction should be found in the issue. labels Jan 5, 2022
@vsaase vsaase mentioned this issue Jan 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Effort: Easy! Start here :D E-pr-welcome The feature is welcome to be added, instruction should be found in the issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanmonstar @vsaase