Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow insert-multi! with empty list of rows #44

Closed
seancorfield opened this issue Jul 10, 2019 · 0 comments
Closed

Allow insert-multi! with empty list of rows #44

seancorfield opened this issue Jul 10, 2019 · 0 comments
Milestone

Comments

@seancorfield
Copy link
Owner

Is your feature request related to a problem? Please describe.
If you are programmatically generating the list of rows to insert, you may have an empty list. This causes insert-multi! to fail.

Describe the solution you'd like
insert-multi! should treat an empty list of rows as a no-op.

Describe alternatives you've considered
Users would need to check the list of rows and only call insert-multi! if it is non-empty but this will require holding on to the head of the list.

Additional context
Some functions already require non-empty data structures -- the ::example-map used for find-by-keys, update!, and delete! are examples.

@seancorfield seancorfield added this to the 1.0.2 milestone Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant