Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exceptions/error reports #477

Open
seancorfield opened this issue Mar 4, 2023 · 2 comments
Open

Improve exceptions/error reports #477

seancorfield opened this issue Mar 4, 2023 · 2 comments
Assignees
Labels
needs analysis I need to think about this!

Comments

@seancorfield
Copy link
Owner

Although ex-data helps a bit in debugging a deeply nested parse failure, it doesn't provide any context. Walking the stack for invokeStatic on honey.sql$format_* calls might be a quick win in getting a "path" into the expression (although it still wouldn't really give expression context).

Instrumenting major formatters to push their expression arguments on a dyn Var bound stack would really help here but would touch a lot of code.

Needs some deep thought!

@seancorfield seancorfield added the needs analysis I need to think about this! label Mar 4, 2023
@seancorfield seancorfield self-assigned this Mar 4, 2023
@seancorfield
Copy link
Owner Author

seancorfield commented Mar 6, 2023

I'm beginning to lean toward the stacktrace walker/formatter after thinking about this for 24 hours...

@seancorfield
Copy link
Owner Author

After some REPL experimentation, that doesn't help at all in relatively simple cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs analysis I need to think about this!
Projects
None yet
Development

No branches or pull requests

1 participant