Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UR5 model display issues #78

Closed
sea-bass opened this issue Jan 11, 2025 · 5 comments · Fixed by #79
Closed

UR5 model display issues #78

sea-bass opened this issue Jan 11, 2025 · 5 comments · Fixed by #79
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sea-bass
Copy link
Owner

According to Gepetto/example-robot-data#177, there are some problems with the UR5 model.

I think the easiest resolution for this repo is to switch to a UR10 model, since that apparently works fine and doesn't really impact this library.

@sea-bass sea-bass added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jan 11, 2025
@sea-bass sea-bass changed the title UR5 display issues UR5 model display issues Jan 11, 2025
@kumar-sanjeeev
Copy link
Contributor

kumar-sanjeeev commented Jan 13, 2025

@sea-bass Can I look into this ?

@kumar-sanjeeev
Copy link
Contributor

kumar-sanjeeev commented Jan 14, 2025

I tried adding ur10_description to the models directory. The comparison is as follows: ur10 (left) and ur5 (right).

If this is okay, what do you think? should we keep separate descriptions for each UR model, like ur5_description and ur10_description (which is what I did in this case), or should we use a single directory, ur_description, containing multiple models for the UR series (ROS-style)?

The screenshot below was taken after running:

python3 examples/intro_pinocchio/intro_pinocchio_ur10_sim.py
python3 examples/intro_pinocchio/intro_pinocchio_ur5_sim.py

image

@sea-bass
Copy link
Owner Author

Cool! Either way is fine.

Seems it would be best to have the Python code have a separate ur5 and ur10 file, but the meshes/descriptions can all live in a single ur_description folder.

@kumar-sanjeeev
Copy link
Contributor

Okay, if I understand correctly, following will be the new ur_description directory structure, and for each arm, we will have separate files: intro_pinocchio_ur10_sim.py and intro_pinocchio_ur5_sim.py. Is that correct?

ur_description
├── meshes
│   ├── ur10
│   └── ur5
├── srdf
│   ├── ur10_gripper.srdf
│   └── ur5_gripper.srdf
└── urdf
    ├── ur10_gripper.urdf
    └── ur5_gripper.urdf

@sea-bass
Copy link
Owner Author

Exactly!

@sea-bass sea-bass linked a pull request Jan 16, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants