-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explanation to Part 1 introduction #89
Conversation
@laney0808 This should be in the PR description (not a separate comment), and should be |
@@ -15,6 +15,13 @@ Imagine yourself as a director of a play. First you provision the props that you | |||
|
|||
A JavaFX application is like a play you are directing. Instead of creating props, you create `Node`s (`Node`s are the fundamental building blocks of a JavaFX application), and place them onto a `Scene` (a scene is a graph of `Node`s). Then, you set your `Scene` on a `Stage` provided by JavaFX. When you call `Stage#show()` method, JavaFX renders a window with your `Stage` on it. | |||
|
|||
<box type="tip" seamless> | |||
The `Stage` is like a window in a desktop application. It is the top-level container for a JavaFX application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could add, for greater clarity, that the Stage consists of different scenes at different times, i.e. depending on the current action/state, the Scene on the Stage is different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point! Will add in the next commit. Thank you!
Adapated from #89 by @laney0808
Thanks for this PR @laney0808 In future, remember to preview the changes locally first. The code in this PR doesn't render as intended because it doesn't have a blank line below the |
Explain the meaning of Stage, Scene, Root node and Node in Part 1 introduction for clarity.
Fixes #90