Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class reorganization #1

Open
2 of 6 tasks
krzysztofarendt opened this issue Jul 12, 2017 · 1 comment
Open
2 of 6 tasks

Class reorganization #1

krzysztofarendt opened this issue Jul 12, 2017 · 1 comment

Comments

@krzysztofarendt
Copy link
Member

krzysztofarendt commented Jul 12, 2017

The package architecture should be reorganized:

  • - Editor should be the main API
  • - to keep Editor.py with a reasonable size use multiple inheritance - specialized methods should be implemented in separate topic-specific subclasses of BasicEdit (only), e.g. GeomEdit, ExtInterfaceEdit, and Editor should inherit from all of them
  • - most of the current functions in std.py should be moved to specialized subclasses of BasicEdit
  • - BasicEdit.apply() should be used for custom user functions
  • - BasicEdit.apply() should not impose the return value of the passes user function
  • - In place edition in BasicEdit.apply() should be removed - user function does not have to modify the selected objects
@krzysztofarendt
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant