Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support drivers other than PostgreSQL #19

Open
albireox opened this issue Sep 22, 2019 · 0 comments
Open

Support drivers other than PostgreSQL #19

albireox opened this issue Sep 22, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@albireox
Copy link
Member

Right now it's hardcoded in sdssdb that all the databases are PostgreSQL. In principle we may need to support other databases (e.g. SQLite or SQL Server) and should be able to use all the current framework. Both Peewee and SQLA support multiple drivers.

On the SQLA side this seems relatively simple, since the driver is specified as a string. For Peewee is a bit more complicated; we'd need to create a PeeweeBaseDatabaseConnection and then subclass from the appropriate Peewee connection class and make sure the __init__ is run correctly.

@albireox albireox added the enhancement New feature or request label Sep 22, 2019
@albireox albireox self-assigned this Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant