Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't seem to trigger correctly in Chrome 47 #36

Open
thomassuckow opened this issue Dec 11, 2015 · 5 comments
Open

Doesn't seem to trigger correctly in Chrome 47 #36

thomassuckow opened this issue Dec 11, 2015 · 5 comments

Comments

@thomassuckow
Copy link
Contributor

Version 47.0.2526.80 (64-bit) OSX

This plugin seems to not trigger when the element reaches its final size. We have an transition that expands a panel with a chart inside, we use this make sure the chart is rendered appropriately (fill the width of the element). In the latest chrome it ends up stretched because it resizes to an intermediate value of the transition and not to the final size.

May be a chrome bug, though I am not sure what I would report/search for.

@thomassuckow
Copy link
Contributor Author

It appears to be specific to the expand detection in my further testing. It would appear that chrome is being a little more touchy.

Increasing the + 1px to +2px seems to have mitigated the problem for me. It bugs me that I don't fully understand why it stopped working. I'm going to try to reproduce the issue in a minimal jsfiddle.

@thomassuckow
Copy link
Contributor Author

http://jsfiddle.net/thomassuckow/gued0nzn/5/

I believe this to be a chrome bug.

@thomassuckow
Copy link
Contributor Author

https://code.google.com/p/chromium/issues/detail?id=584443

Though it is probably worth changing to 2px, just in case rounding issues come up again or in other browsers.

@colllin
Copy link

colllin commented May 22, 2016

Nice find @thomassuckow . So is this issue closed?

@thomassuckow
Copy link
Contributor Author

Only on cosmicexplorers fork. Ideally someone would backport it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants