Skip to content
This repository has been archived by the owner on Feb 3, 2018. It is now read-only.

Refactor low-level Source operations for better reuse #112

Closed
sdboyer opened this issue Oct 17, 2016 · 1 comment
Closed

Refactor low-level Source operations for better reuse #112

sdboyer opened this issue Oct 17, 2016 · 1 comment

Comments

@sdboyer
Copy link
Owner

sdboyer commented Oct 17, 2016

There's a lot of inter-calls on baseVCSSource, and its derived types, as they exist today. These types have seen...uh, let's call it "organic growth," and are turning into spaghetti. The main problems are:

  • Pretty much all of the methods take out locks - both the "porcelain" and the "plumbing." As a result, porcelain often ends up reimplementing plumbing, as calling the plumbing would deadlock.
  • There's a proliferation of individual bits, flags, bools, etc., which represent separate but interrelated states. These need to be consolidated and managed better.

Basically, I got lazy and started focusing on actions, rather than retaining the overall-consistent-state approach, and let things fall into disrepair.

@sdboyer
Copy link
Owner Author

sdboyer commented Apr 16, 2017

This is fixed by #196

@sdboyer sdboyer closed this as completed Apr 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant