when_all: add Sentinel support to when_all_succeed() #2565
Merged
+34
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enhances the `iterator_range_estimate_vector_capacity()` helper function to support ranges with potentially different iterator and sentinel types. Key improvements include: - Replace iterator category parameter with C++20 iterator concepts - Use `std::ranges::distance()` for robust distance calculation - Prepare groundwork for range support in `when_all_succeed()` - Remove outdated comment about O(n) performance for random access iterators The modification allows the function to work with a broader range of iterator types, including those from standard library ranges with heterogeneous iterator and sentinel types. Signed-off-by: Kefu Chai <[email protected]>
Extend `when_all_succeed()` to accept ranges with heterogeneous iterator and sentinel types by adding a separate template parameter for the sentinel. Signed-off-by: Kefu Chai <[email protected]>
tchaikov
force-pushed
the
when-all-with-ranges
branch
from
5c7dd23 to
156f5e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend
when_all_succeed()anditerator_range_estimate_vector_capacity()to accept ranges with heterogeneous iteratorand sentinel types by adding a separate template parameter for the sentinel.