Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC: get_stream formats connection_id as boolean #1151

Closed
xemul opened this issue Jul 22, 2022 · 2 comments
Closed

RPC: get_stream formats connection_id as boolean #1151

xemul opened this issue Jul 22, 2022 · 2 comments

Comments

@xemul
Copy link
Contributor

xemul commented Jul 22, 2022

As seen in scylladb/scylladb#10950, this code

throw std::logic_error(format("rpc stream id {} not found", id).c_str());

results in

std::logic_error (rpc stream id true not found)

message. Apparently compiler picks up implicit connection_id::operator bool() const to format :D
@xemul
Copy link
Contributor Author

xemul commented Jul 25, 2022

fmtlib/fmt#2624

@xemul
Copy link
Contributor Author

xemul commented Jul 25, 2022

fmtlib/fmt#1766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xemul