Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Decipher post-training methods #3091

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

justjhong
Copy link
Contributor

*TODO: merge trajectory methods PR into this PR (chunked for ease of review)

Adds the following downstream methods to the Decipher class.

  • rotate_decipher_components
  • compute_imputed_gene_expression
  • compute_decipher_time
  • compute_gene_patterns

This is the remaining functionality desired to transfer from the original implementation.
Note, this implementation takes a more scvi-tools-esque approach to each of the methods,
avoiding saving results to the anndata object directly.

cc @ANazaret

@justjhong justjhong requested a review from canergen December 13, 2024 03:57
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.66%. Comparing base (77a1458) to head (84d8378).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/scvi/external/decipher/utils/_utils.py 87.50% 6 Missing ⚠️
src/scvi/external/decipher/_model.py 90.90% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (77a1458) and HEAD (84d8378). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (77a1458) HEAD (84d8378)
13 3
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3091      +/-   ##
==========================================
- Coverage   90.09%   84.66%   -5.44%     
==========================================
  Files         178      180       +2     
  Lines       15118    15190      +72     
==========================================
- Hits        13621    12861     -760     
- Misses       1497     2329     +832     
Files with missing lines Coverage Δ
src/scvi/external/decipher/utils/__init__.py 100.00% <100.00%> (ø)
src/scvi/external/decipher/_model.py 97.36% <90.90%> (-2.64%) ⬇️
src/scvi/external/decipher/utils/_utils.py 87.50% <87.50%> (ø)

... and 22 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant