feat: added provider function, converted to standalone and used inject function #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckwards compatibility Made it return EnvironmentProviders in order to not be misused in component providers but only on bootstrapApplication providers or route providers
LcsGa
approved these changes
Apr 30, 2023
|
🎉 This PR is included in version 16.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Dixyx
pushed a commit
to Dixyx/ngx-toastr
that referenced
this pull request
Nov 22, 2023
…ject (scttcper#991)" This reverts commit 94dba28.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I love this library and use it a lot, lately I've been using it in standalone apps, and always wrapped the ToastModule.forRoot in a custom provider function.
I created this PR to easily use a provider function from the library itself, and also re-use it in the module providers, in order for this change to be backwards compatible.
Also converted the components to standalone and also re-exported them from the modules for backwards compatibility.
Fixes: #986, and I may also add readme changes for #968.