Make aggregation circuit generic over number of snarks

[zhenfeizhang]

Description

[PR description]

Issue Link

[link issue here]

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Contents

• [item]

Rationale

[design decisions and extended information]

How Has This Been Tested?

[explanation]

---

How to fill a PR description

Please give a concise description of your PR.

The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.

MUST: Reference the issue to resolve

Single responsability

Is RECOMMENDED to create single responsibility commits, but not mandatory.

Anyway, you MUST enumerate the changes in a unitary way, e.g.

This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....

Design choices

RECOMMENDED to:

• What types of design choices did you face?
• What decisions you have made?
• Any valuable information that could help reviewers to think critically

[z2trillion]

I will make a separate PR that just removes all the dead code outright.

[z2trillion]

#1253

[lispc]

i feel it may not be necessary to use constant generic. Anyway not bad. Since it is already written, we can use it.

// oh useful for testing?

[lispc]

if we still use chunk num = 15, we don't need to increase nums here?

[z2trillion]

I am looking into what changes caused the increased column usage. The params were set to their previous values here: increased edb0ae7

[z2trillion]

i feel it may not be necessary to use constant generic. Anyway not bad. Since it is already written, we can use it.

// oh useful for testing?

Yes, it is mainly for testing. The other option I considered was to use feature flags to vary MAX_AGG_SNARKS, but I thought that that would be harder to maintain.

[lispc]

Seems you have to increase columns a bit. Try increase as small as possible

[z2trillion]

Seems you have to increase columns a bit. Try increase as small as possible

The existing change by zhenfei is the minimum necessary.