This repository was archived by the owner on Apr 18, 2025. It is now read-only.
feat: implement access list address and storage key lookups in copy circuit (EIP-2930)#1058
Merged
Conversation
silathdiir
requested review from
DreamWuGit,
darth-cy,
kunxian-xia,
lispc and
roynalnaruto
roynalnaruto
reviewed
Dec 8, 2023
roynalnaruto
left a comment
roynalnaruto
left a comment
There was a problem hiding this comment.
Nitpick suggestions. And some refactoring suggestions. Will wait for further updates before doing another round of review :)
silathdiir
changed the title
silathdiir
changed the title
…::default()` with `access_list: vec![]` in call places.
roynalnaruto
approved these changes
Dec 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
access_listtoCopyEvent, and assign access list address tovalueand storage key tovalue_prevof copy table, and assignaddrtoindexof tx table.Add both access list address and storage key copy events in begin-tx.
In copy circuit, for access list do TX lookups as read steps, and RW lookups as write steps. Since there is no real bytes to copy, the copy bytes is just intialized to create read and write steps, and no word alignment (as other copy data type).
Only enable RW lookups in copy circuit for now, just comment out TX lookups to wait for merging this EIP-1559 PR which implements tx table load for access list.
Test
TODO
Asana