[feat] remove stack

bus-mapping/src/evm/opcodes/callop.rs

@@ -500,6 +500,7 @@ impl<const N_ARGS: usize> Opcode for CallOpcode<N_ARGS> {
 
                     let mut oog_step =
                         ErrorOOGPrecompile::gen_associated_ops(state, &geth_steps[1], callee_call)?;
+                    oog_step.stack_size += 1; // since the return value is pushed on the stack
 
                     oog_step.gas_left = Gas(callee_gas_left_with_stipend);
                     oog_step.gas_cost = GasCost(precompile_call_gas_cost);

bus-mapping/src/evm/opcodes/create.rs

@@ -29,6 +29,7 @@ impl<const IS_CREATE2: bool> Opcode for Create<IS_CREATE2> {
 
         let tx_id = state.tx_ctx.id();
         let caller = state.call()?.clone();
+
         let address = if IS_CREATE2 {
             state.create2_address(&geth_steps[0])?
         } else {
@@ -54,8 +55,6 @@ impl<const IS_CREATE2: bool> Opcode for Create<IS_CREATE2> {
         let callee = if is_precheck_ok && !is_address_collision {
             state.parse_call(geth_step)?
         } else {
-            // if precheck not ok, the call won't appear in call trace since it never happens
-            // we need to increase the offset and mannually set the is_success
             state.tx_ctx.call_is_success_offset += 1;
             let mut call = state.parse_call_partial(geth_step)?;
             call.is_success = false;

bus-mapping/src/evm/opcodes/precompiles/mod.rs

@@ -30,7 +30,8 @@ pub fn gen_associated_ops(
     output_bytes: &[u8],
     return_bytes: &[u8],
 ) -> Result<ExecStep, Error> {
-    let input_step = state.new_step(&geth_step)?;
+    let mut input_step = state.new_step(&geth_step)?;
+    input_step.stack_size += 1; // since the return value is pushed on the stack
 
     gen_ops(
         state,

zkevm-circuits/src/super_circuit/precompile_block_trace.rs

@@ -809,7 +809,7 @@ pub(crate) fn block_invalid_precompile() -> BlockTrace {
     let addr_d = address!("0x000000000000000000000000000000000000DDDD");
 
     // 4 accounts and 3 txs.
-    TestContext::<4, 3>::new(
+    TestContext::<4, 1>::new(
         Some(vec![Word::zero()]),
         |accs| {
             accs[0].address(addr_a).balance(Word::from(1u64 << 24));
@@ -831,14 +831,14 @@ pub(crate) fn block_invalid_precompile() -> BlockTrace {
                 .from(wallet_a.clone())
                 .to(accs[1].address)
                 .gas(Word::from(2_000_000u64));
-            txs[1]
-                .from(wallet_a.clone())
-                .to(accs[2].address)
-                .gas(Word::from(2_000_000u64));
-            txs[2]
-                .from(wallet_a.clone())
-                .to(accs[3].address)
-                .gas(Word::from(2_000_000u64));
+            // txs[1]
+            //     .from(wallet_a.clone())
+            //     .to(accs[2].address)
+            //     .gas(Word::from(2_000_000u64));
+            // txs[2]
+            //     .from(wallet_a.clone())
+            //     .to(accs[3].address)
+            //     .gas(Word::from(2_000_000u64));
         },
         |block, _tx| block.number(0xcafeu64),
     )